Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sushi should warn/error when an invalid code in a locally defined CodeSystem is referenced #595

Closed
saulakravitz opened this issue Sep 4, 2020 · 3 comments · Fixed by #930

Comments

@saulakravitz
Copy link

Currently, if an invalid code from a locally defined CodeSystem is referenced, no warning/error is generated in both Profiles and Examples. Should generate an error in both, IMHO. Or at least a warning.

@cmoesel
Copy link
Member

cmoesel commented Sep 14, 2021

I realize this issue is a year old. Sorry for the late response. My only concern is that it might be confusing for SUSHI to do this type of validation in some cases (for local codes) but not for other cases (e.g., LOINC codes). Do you think that might confuse authors? If you got an error/warning about MYCS#foo being invalid, might you assume that since you got no error for LOINC#bar that it is valid?

@saulakravitz
Copy link
Author

  1. The IG publisher is the final arbiter
  2. Anything that Sushi can do to shorten the edit-compile-debug loop is a blessing to the developer. Each time sushi flags a reference to a locally defined codesystem that is incorrect saves 5-10 minutes of time. Definitely worth it IMHO.

@cmoesel
Copy link
Member

cmoesel commented Sep 14, 2021

Thanks for the feedback, @saulakravitz. I'll add it to the backlog. Can't say when it will get done, but it'll at least be on the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants