Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUSHI should report error when fixing values on root path that is sliced and fixed in the slice #227

Closed
cmoesel opened this issue Feb 17, 2020 · 0 comments · Fixed by #259
Assignees
Labels
bug Something isn't working released Available in an official SUSHI release

Comments

@cmoesel
Copy link
Member

cmoesel commented Feb 17, 2020

This is best explained by example:

Profile: MyProcedureLabProfile
Parent: http://hl7.org/fhir/us/core/StructureDefinition/us-core-observation-lab
* category = OBSCAT#procedure

US Core slices category and fixes the Laboratory slice to laboratory. The rule * category = OBSCAT#procedure, however, implies a single allowed value (which is not laboratory). Therefore, SUSHI should report an error (after all, the IG Publisher does).

In addition, we probably should think in general about what it means for an author to fix a value on a multi-cardinality path. Should we emit a warning (even when there is no conflict w/ an existing slice) since the intent probably isn't to fix every element in the array (and slicing would be more appropriate)?

@cmoesel cmoesel added the bug Something isn't working label Feb 17, 2020
@mint-thompson mint-thompson self-assigned this Feb 19, 2020
@cmoesel cmoesel added the released Available in an official SUSHI release label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in an official SUSHI release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants