Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add arbitrary extensions to example instances #188

Closed
Healthedata1 opened this issue Feb 3, 2020 · 1 comment · Fixed by #216
Closed

Can't add arbitrary extensions to example instances #188

Healthedata1 opened this issue Feb 3, 2020 · 1 comment · Fixed by #216
Assignees
Labels
bug Something isn't working released Available in an official SUSHI release

Comments

@Healthedata1
Copy link

An instance ( example) should be able to have any number of extensions even if they are not defined inline. Right now an extension in an instance that not defined as part of the SD is causing the the instance not be generated.

@cmoesel
Copy link
Member

cmoesel commented Feb 3, 2020

Agreed. The extension should not have to be specified in the profile in order to use it. Thanks for the report.

The one potential caveat/issue is that if you reference an extension that is not in one of the declared package dependencies, SUSHI will not know anything about that extension -- so we'd either need to take the author's word for it (and generate it exactly as-specified in the FSH) or throw out an error since we can't process usages of unknown (to SUSHI) extensions. But I think that's a slightly different issue.

@cmoesel cmoesel added the bug Something isn't working label Feb 3, 2020
@ngfreiter ngfreiter self-assigned this Feb 12, 2020
@cmoesel cmoesel added the released Available in an official SUSHI release label Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in an official SUSHI release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants