Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUSHI should not include instances of custom resources in the IG #1090

Closed
cmoesel opened this issue May 18, 2022 · 1 comment · Fixed by #1115
Closed

SUSHI should not include instances of custom resources in the IG #1090

cmoesel opened this issue May 18, 2022 · 1 comment · Fixed by #1115
Labels
bug Something isn't working

Comments

@cmoesel
Copy link
Member

cmoesel commented May 18, 2022

The IG Publisher does not support custom resources. SUSHI already suppresses custom resources from the generated IG JSON. If an author creates an example of a custom resource, however, SUSHI does still include that instance in the IG JSON. This then causes problems in the IG Publisher (since it's referencing a custom resource). SUSHI should probably suppress instances of custom resources too.

See: https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/bad.20resource.20identity/near/282797466

Example FSH from issue reported on Zulip:

Resource: FormTemplate
Parent: Resource
Id: formtemplate
Title: "FHIR2 Form Template"
Description: "FHIR2 Form Template"
* template 1..1 BackboneElement "The root of the doc"
  * templateStatus 1..1 string "the template status"


Instance: FHIR2FormTemplateExample
InstanceOf: FormTemplate
Title: "Example : Questionnaire"
Description: "Example : Questionnaire"
Usage: #example
* template.templateStatus = "draft"
@cmoesel cmoesel added bug Something isn't working added to backlog labels May 18, 2022
@guhanthuran
Copy link
Contributor

Should this also include a warning that we aren't including these instances in the IG?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants