Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using String#codePointAt()? #14

Open
ashi009 opened this issue Aug 16, 2016 · 1 comment
Open

Using String#codePointAt()? #14

ashi009 opened this issue Aug 16, 2016 · 1 comment

Comments

@ashi009
Copy link

ashi009 commented Aug 16, 2016

I noticed that the code converts utf8 to utf16 manually, however String#codePointAt() is already standardized for quite a while.

I think switch to use the built in version should give unidecode a huge performance boost.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/36986931-using-string-codepointat?utm_campaign=plugin&utm_content=tracker%2F294213&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F294213&utm_medium=issues&utm_source=github).
@FGRibreau
Copy link
Owner

Hello @ashi009,

Indeed, I will accept a PR for it if the tests pass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants