Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEX tests may generate unwanted instruction form #4150

Open
OFFTKP opened this issue Oct 30, 2024 · 1 comment
Open

FEX tests may generate unwanted instruction form #4150

OFFTKP opened this issue Oct 30, 2024 · 1 comment

Comments

@OFFTKP
Copy link

OFFTKP commented Oct 30, 2024

I am not 100% sure if I am right here, so apologies if I am not.
I was looking at test OpSize/66_D6.asm which has the instruction:
movq xmm0, xmm2
This on NASM generates the (probably unintended) form:
movq xmm0, xmm2 ; +0 = f3 0f 7e c2 (https://godbolt.org/z/ebWchEcbb)
While I assume the one that the test focuses on testing is the form:
movq xmm0, xmm2 ; +0 = 66 0f d6 d0

I assume this doesn't cause any real problems, but I thought you might want to know that the test doesn't test the reg/reg form of the D6 opcode (if I am right).

This may or may not also happen on other tests that have both a xmm/xmm128 and a xmm128/xmm form where NASM compiles them to the unintended form.

@Sonicadvance1
Copy link
Member

You're right, when I was writing the tests I probably assumed in some cases that nasm was generating the correct opcodes. I'll need to go to that test and resolve it. There's likely to be more that this happens with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants