Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoefficientsType should require at least one Numerator #56

Open
crotwell opened this issue Oct 1, 2020 · 2 comments
Open

CoefficientsType should require at least one Numerator #56

crotwell opened this issue Oct 1, 2020 · 2 comments
Labels

Comments

@crotwell
Copy link
Collaborator

crotwell commented Oct 1, 2020

Mathematically, a Coefficients filter has to have at least one numerator, which can be 1. Otherwise the output time series would be all zeros.

A no-coefficient Coefficient filter might be used to just be a container for units, but this should be discouraged. Requiring at least one numerator would force using of at least a single coefficient, even if it is 1.

Change:

<xs:element name="Numerator" minOccurs="0" maxOccurs="unbounded">

to

<xs:element name="Numerator" minOccurs="1" maxOccurs="unbounded">

Similarly a FIR filter should have at least one NumeratorCoefficient so change

<xs:element name="NumeratorCoefficient" minOccurs="0" maxOccurs="unbounded">

to

<xs:element name="NumeratorCoefficient" minOccurs="1" maxOccurs="unbounded">
@rcasey-earthscope
Copy link

Seems reasonable to me.

@crotwell
Copy link
Collaborator Author

Related, docs currently say "Laplace transforms or IIR filters can both be expressed" with Coefficients, but I think they meant "analog filters" instaed of IIR filters. It makes sense to me to represent a digital IIR filter with coefficients, especially if implemented in the time domain.

See PR #126 for doc fix for this, but not schema change.

@crotwell crotwell added the pr review needed Fixed in PR, needs review and merge label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants