Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer statistics were removed. Should they be restored? #97

Open
vodik opened this issue Apr 18, 2018 · 3 comments
Open

Peer statistics were removed. Should they be restored? #97

vodik opened this issue Apr 18, 2018 · 3 comments
Labels

Comments

@vodik
Copy link
Contributor

vodik commented Apr 18, 2018

So #94 pulled out the Peer's contact/registered/subscriber attributes.

I've never personally found them useful, and have always implemented them myself in my REGISTER and SUBSCRIBE handlers - especially since different projects of mine do them slightly differently.

Should we restore them? Drop it?

@vodik vodik added the question label Apr 18, 2018
@vodik
Copy link
Contributor Author

vodik commented Apr 18, 2018

If you guys relied on them, I don't mind putting in the effort to restore them.

@ovv
Copy link
Contributor

ovv commented Apr 19, 2018

I'm not sure we need them with the dialog rework, we probably don't need to re add them for the moment.

I'm going to get back into aiosip for a project and probably make some improvements / bugfix for what I need. I'll also try to put the releases into travis so that will be easier for everybody

@vodik
Copy link
Contributor Author

vodik commented Apr 19, 2018

Nice, works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants