Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native-svg v13 support #164

Open
GunnarAK opened this issue Sep 18, 2022 · 12 comments
Open

react-native-svg v13 support #164

GunnarAK opened this issue Sep 18, 2022 · 12 comments

Comments

@GunnarAK
Copy link

v13 dropped a month ago

npm i react-native-qrcode-svg
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react-native-svg
npm ERR!   react-native-svg@"^13.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react-native-svg@"^12.1.0" from [email protected]
npm ERR! node_modules/react-native-qrcode-svg
npm ERR!   react-native-qrcode-svg@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/gunnark/.npm/eresolve-report.txt for a full report.
@AndreiBelokopytov
Copy link

+1 for this issue

@kaycklbr
Copy link

Up

@romarpla
Copy link

+1 having the same error

@B0Y3R
Copy link

B0Y3R commented Nov 21, 2022

+1 having some issue

@GunnarAK
Copy link
Author

GunnarAK commented Nov 22, 2022

@awesomejerry I wanted to have a look at upgrading this myself, but I got stuck with installing the example app locally.
I'm using node 14 (via nvm).
Installing root package.json first, then example package.json. Via npm install

The Metro packager is not able to locate the react-native-qrcode-svg package as it is a symbolic link in the app's node_modules. And as far as I'm aware after 5 years and counting Metro still does not support sym links facebook/metro#1

So how do you go about this? There's no documentation inside the example project which would be of help here unfortunately.

Error example:

iOS Bundling failed 220ms
Unable to resolve module react-native-qrcode-svg from /Users/gunnark/Repositories/personal/react-native-qrcode-svg/example/App.js: react-native-qrcode-svg could not be found within the project or in these directories:
  node_modules
  ../node_modules

Also, why does the example app have both a yarn.lock & package-lock.json file?

@emmanuelmahove
Copy link

+1 also experiencing this issue

@ansh-dagha
Copy link

+1 having same error

@brad-ps
Copy link

brad-ps commented Nov 30, 2022

+1 same here

@onkr0d
Copy link

onkr0d commented Dec 7, 2022

+1 same issue

@1level1
Copy link

1level1 commented Dec 14, 2022

+1

@ccoloma
Copy link

ccoloma commented Jan 10, 2023

Until #166 is merged, you can use the overrides field on your package.json if npm is >=8.3.0

{
  ...
  "dependencies": {
    ...
    "react-native-qrcode-svg": "^6.1.2",
    "react-native-svg": "^13.6.0",
    ...
  },
  "overrides": {
    "react-native-qrcode-svg": {
      "react-native-svg": "$react-native-svg"
    }
  },
  ...
}

@BraveEvidence
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests