Migrate to npm #539
Merged
Migrate to npm #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SzymczakJ
force-pushed
the
@szymczak/migrate-to-npm
branch
from
b35c6bd
to
7e57c4f
Compare
SzymczakJ
commented
Nov 7, 2024
| @@ -14,18 +14,7 @@ const modules = Object.keys({...pak.peerDependencies}); | |||
| * @type {import('metro-config').MetroConfig} | |||
| */ | |||
| const config = { | |||
| watchFolders: [root], | |||
There was a problem hiding this comment.
| @@ -11,9 +11,9 @@ react { | |||
| // The root of your project, i.e. where "package.json" lives. Default is '../..' | |||
| // root = file("../../") | |||
| // The folder where the react-native NPM package is. Default is ../../node_modules/react-native | |||
| // reactNativeDir = file("../../node_modules/react-native") | |||
| reactNativeDir = file("../../../node_modules/react-native") | |||
There was a problem hiding this comment.
| @@ -56,7 +56,7 @@ jobs: | |||
| example/ios/Pods | |||
| ~/Library/Caches/CocoaPods | |||
| ~/.cocoapods | |||
| key: build-ios-pods-${{ matrix.react-native-architecture }}-${{ hashFiles('example/node_modules/react-native/package.json') }} | |||
There was a problem hiding this comment.
tomekzaw
reviewed
Nov 11, 2024
WebExample/App.tsx
Outdated
| @@ -1,3 +1,4 @@ | |||
| import App from '../example/src/App'; | |||
| import App from '@expensify/react-native-live-markdown-example/src/App'; | |||
There was a problem hiding this comment.
Fast refresh is broken because of this change.
Closed
tomekzaw
requested changes
Nov 21, 2024
tomekzaw
previously approved these changes
Nov 21, 2024
tomekzaw
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Related Issues
GH_LINK
Manual Tests
Linked PRs