Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename type Range to MarkdownRange #464

Merged
merged 3 commits into from
Aug 31, 2024
Merged

Conversation

tomekzaw
Copy link
Collaborator

@tomekzaw tomekzaw commented Aug 30, 2024

Details

This PR renames type Range to MarkdownRange to avoid confusion with type Range from Web API, by the way also used in the codebase.

Related Issues

GH_LINK

Manual Tests

Linked PRs

Skalakid
Skalakid previously approved these changes Aug 30, 2024
Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Btw in parserUtils we have the same MarkdownRange type, so it would be nice to merge them into one

BartoszGrajdek
BartoszGrajdek previously approved these changes Aug 30, 2024
@tomekzaw tomekzaw merged commit f3033b9 into main Aug 31, 2024
3 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/rename-type-range branch August 31, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants