Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to use ExpensiMark in worklets #764

Merged

Conversation

tomekzaw
Copy link
Contributor

This PR adds 'worklet'; directive in file ExpensiMark.ts (as well as some of its dependencies, namely str.ts and utils.ts) so that class ExpensiMark can be used instantiated and used in worklets.

When 'worklet'; directive is located at the top of the file, all functions, classes and object methods in the top-level scope of within this file are workletized.

Worklets are short-running JS functions that can be run on the UI thread. We need to run ExpensiMark on the UI thread synchronously as the user types inside MarkdownTextInput so we can format its contents synchronously.

Fixed Issues

$ Expensify/react-native-live-markdown#317

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  2. What tests did you perform that validates your changed worked?

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?

@tomekzaw tomekzaw requested a review from a team as a code owner July 25, 2024 09:20
@melvin-bot melvin-bot bot requested review from youssef-lr and removed request for a team July 25, 2024 09:20
@roryabraham roryabraham merged commit 1f2a3a3 into Expensify:main Jul 25, 2024
6 checks passed
Copy link

🚀Published to npm in v2.0.55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants