Make it possible to use ExpensiMark in worklets #764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
'worklet';
directive in fileExpensiMark.ts
(as well as some of its dependencies, namelystr.ts
andutils.ts
) so that classExpensiMark
can be used instantiated and used in worklets.When
'worklet';
directive is located at the top of the file, all functions, classes and object methods in the top-level scope of within this file are workletized.Worklets are short-running JS functions that can be run on the UI thread. We need to run ExpensiMark on the UI thread synchronously as the user types inside
MarkdownTextInput
so we can format its contents synchronously.Fixed Issues
$ Expensify/react-native-live-markdown#317
Tests
QA