-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rules to recognize user and @here
mentions
#524
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Another couple of things @getusha.
|
I have read the CLA Document and I hereby sign the CLA |
recheck |
@puneetlath yes I am considering the stylings too, |
@mananjadhav looks like you need to comment so that we can assign you. |
@getusha Can we please add tests for the rules? Considering all the scenarios like styling, codefence, email, mentions not rendered as hyperlink, etc.
@puneetlath I think this comment should help? |
It didn't let me assign, but the moment I added review comments it added me as a reviewer. |
@mananjadhav @puneetlath |
17279a5
to
b42ed3a
Compare
@puneetlath |
It looks like it worked for commit signing, but it also looks like you lost some of your changes. For example, it seems like all your |
An easier method might be to take your changes as of afb1d85 and move it to a new branch and open a new PR. |
Yes, that would be easier. lets check it one more time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok it does look like we have the same changes as before now, so approving.
Ok, I approved @getusha but we're still getting the signed commits error. |
Alright, i will raise a new PR |
Opened a new PR here, going to close this one. |
*/ | ||
{ | ||
name: 'userMentions', | ||
regex: new RegExp(`((`|<code>|<pre>)\\s*?)?[\`.a-zA-Z]?@+${CONST.REG_EXP.EMAIL_PART}`, 'gm'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@getusha Why do we need a @+
can't it just be @
as we need just only one @
. As this seems like causing a regression for more info check this Expensify/App#28946 (comment) Let us know if are we missing something.
cc: @mananjadhav
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Santhosh-Sellavel I am not sure if i remember that correctly, but if all tests are passing i think its safe to remove it.
@mananjadhav @puneetlath
Fixed Issues
$ Expensify/App#17882
Tests
@jhon
,@david
@here
mention<mention-user>mention</mention-user>
and the@here
should be<mention-here>@here</mention-here>
QA
Same as tests