Krishna2323/issue/49286 #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: krishna2323 <[email protected]>
Signed-off-by: krishna2323 <[email protected]>
6 tasks
lib/str.ts
Outdated
| * @returns The formatted URL | ||
| */ | ||
| sanitizeURL(url: string): string { | ||
| sanitizeURL(url: string, scheme = 'https'): string { |
There was a problem hiding this comment.
Suggested change
| sanitizeURL(url: string, scheme = 'https'): string { | |
| sanitizeURL(url: string, defaultScheme = 'https'): string { |
There was a problem hiding this comment.
I think defaultScheme is more meaningful because it uses only as a default value if the URL didn't have a scheme. We also need to update the comment and its usage.
There was a problem hiding this comment.
We can also add a unit to confirm that
expect(Str.sanitizeURL('https://example.com', 'http')).toBe('https://example.com');
|
@rlinoz I'll take over as I'm assigned to the parent issue |
|
@Krishna2323 bump for the above review |
Signed-off-by: krishna2323 <[email protected]>
__tests__/Str-test.js
Outdated
| expect(Str.sanitizeURL('FOO.com/blah_BLAH')).toBe('https://foo.com/blah_BLAH'); | ||
| +expect(Str.sanitizeURL('FOO.com/blah_BLAH', 'http')).toBe('http://foo.com/blah_BLAH'); | ||
| +expect(Str.sanitizeURL('example.com', 'http')).toBe('http://example.com'); | ||
| expect(Str.sanitizeURL('https://example.com', 'http')).toBe('http://example.com'); |
There was a problem hiding this comment.
Suggested change
| expect(Str.sanitizeURL('https://example.com', 'http')).toBe('http://example.com'); | |
| expect(Str.sanitizeURL('https://example.com', 'http')).toBe('https://example.com'); |
There was a problem hiding this comment.
@Krishna2323 Let's finish it.
Signed-off-by: krishna2323 <[email protected]>
marcaaron
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues
$ GH_LINK Expensify/App#49286
Details: This PR updates the
sanitizeURLutility function to accept a new parameter,scheme. Theschemeparameter allows us to specify the scheme as needed. The default value ishttps, but we can passhttpor any other scheme as the scheme parameter to override it.Tests
QA