fix: remove String.replaceAll polyfill #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
melvin-bot
bot
requested review from
neil-marcellini
and removed request for
a team
|
I have read the CLA Document and I hereby sign the CLA |
This comment was marked as off-topic.
This comment was marked as off-topic.
neil-marcellini
approved these changes
Jan 15, 2024
|
I also confirmed that all our repos using expensify-common are using a node version >= 15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the String.replaceAll ployfill in an attempt to reduce the bundle size. String.replaceAll method is natively supported from NodeJS v15 onwards. So the polyfill is not needed any more. This removes appoximately 30KB from overall bundle size.
Fixed Issues
$ GH_LINK Expensify/App#31183
Tests
What unit/integration tests cover your change? What autoQA tests cover your change?
No new test cases required. Str.replaceAll method now makes use of built-in String.replace method. So all existing test cases should pass.
What tests did you perform that validates your changed worked?
QA
What does QA need to do to validate your changes?
Same as tests
What areas to they need to test for regressions?
Str.replaceAll is used in Emoji and comment parsing in Expensify app. Test by adding/removing emojis in chats.