Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Straight revert of 2 PRs without involving any resolve conflict situation #568

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

techievivek
Copy link
Contributor

Reverts
#561
#567

Fixed Issues

https://expensify.slack.com/archives/C05PJA1M5BJ/p1692799880392129?thread_ts=1692741519.031649&cid=C05PJA1M5BJ

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  2. What tests did you perform that validates your changed worked?

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?

@techievivek techievivek self-assigned this Aug 23, 2023
@techievivek techievivek requested a review from a team as a code owner August 23, 2023 14:17
@melvin-bot melvin-bot bot requested review from stitesExpensify and removed request for a team August 23, 2023 14:17
@techievivek techievivek merged commit 4948102 into main Aug 23, 2023
3 checks passed
@techievivek techievivek deleted the techievivek_revert_currency_change branch August 23, 2023 14:22
@melvin-bot melvin-bot bot added the Emergency Marks a change in which we bypassed our normal process (eg, skipped travis) label Aug 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2023

@techievivek looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@techievivek techievivek removed the Emergency Marks a change in which we bypassed our normal process (eg, skipped travis) label Aug 23, 2023
@techievivek
Copy link
Contributor Author

Not an emergency merge, tests were passing.

Screenshot 2023-08-23 at 7 53 08 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants