Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Meet Guide Task #57487

Merged
merged 4 commits into from
Feb 26, 2025
+4 −16
Merged

Remove Meet Guide Task #57487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2e31b2
remove meet guide task
MarioExpensify Feb 26, 2025
924bd25
fix affected unit test
MarioExpensify Feb 26, 2025
f1f262f
fix task count for test
MarioExpensify Feb 26, 2025
4f525c3
prettier
MarioExpensify Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,16 +124,6 @@ const createWorkspaceTask: OnboardingTask = {
`*Your new workspace is ready!* [Check it out](${workspaceSettingsLink}).`,
};

const meetGuideTask: OnboardingTask = {
type: 'meetGuide',
autoCompleted: false,
title: 'Meet your setup specialist',
description: ({adminsRoomLink}) =>
`Meet your setup specialist, who can answer any questions as you get started with Expensify. Yes, a real human!\n` +
'\n' +
`Chat with the specialist in your [#admins room](${adminsRoomLink}).`,
};

const setupCategoriesTask: OnboardingTask = {
type: 'setupCategories',
autoCompleted: false,
Expand Down Expand Up @@ -5178,7 +5168,6 @@ const CONST = {
tasks: [
createWorkspaceTask,
selfGuidedTourTask,
meetGuideTask,
{
type: 'setupCategoriesAndTags',
autoCompleted: false,
Expand Down Expand Up @@ -5277,7 +5266,6 @@ const CONST = {
},
tasks: [
createWorkspaceTask,
meetGuideTask,
setupCategoriesTask,
{
type: 'inviteAccountant',
Expand Down Expand Up @@ -5346,7 +5334,6 @@ const CONST = {
[onboardingChoices.ADMIN]: {
message: "As an admin, learn how to manage your team's workspace and submit expenses yourself.",
tasks: [
meetGuideTask,
{
type: 'reviewWorkspaceSettings',
autoCompleted: false,
Expand Down
7 changes: 4 additions & 3 deletions tests/actions/PolicyTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,9 @@ describe('actions/Policy', () => {
expect(reportAction.pendingAction).toBe(CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD);
expect(reportAction.actorAccountID).toBe(ESH_ACCOUNT_ID);
});
// Created report action and and default MANAGE_TEAM intent tasks (7) assigned to user by guide, signingoff messages (1)
expect(adminReportActions.length).toBe(9);
// Created Report Action, MANAGE_TEAM tasks (minus tasks that requires integrations to be enabled) and signoff message
const manageTeamDefaultTaskCount = CONST.ONBOARDING_MESSAGES[CONST.ONBOARDING_CHOICES.MANAGE_TEAM].tasks.length - 2;
expect(adminReportActions.length).toBe(2 + manageTeamDefaultTaskCount);
let createdTaskReportActions = 0;
let signingOffMessage = 0;
let taskReportActions = 0;
Expand All @@ -160,7 +161,7 @@ describe('actions/Policy', () => {
});
expect(createdTaskReportActions).toBe(1);
expect(signingOffMessage).toBe(1);
expect(taskReportActions).toBe(7);
expect(taskReportActions).toBe(manageTeamDefaultTaskCount);

// Check for success data
(fetch as MockFetch)?.resume?.();
Expand Down