Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Pusher undefined authtoken #472

Closed
wants to merge 2 commits into from

Conversation

sketchydroide
Copy link
Contributor

related to #429
but at the moment this is more investigative

@tgolen
Copy link
Contributor

tgolen commented Sep 11, 2020

cc @marcaaron

@sketchydroide sketchydroide changed the title Pusher undefined authtoken [WIP] Pusher undefined authtoken Sep 11, 2020
@sketchydroide
Copy link
Contributor Author

GH auto added @tgolen and @AndrewGable as reviewers, I'm very sure I didn't manually added you both to the PR

@sketchydroide
Copy link
Contributor Author

is it because you are both code owners? should I start using the draft instead?

@AndrewGable
Copy link
Contributor

Feel free to use Draft PRs 👍

@tgolen and I are code owners so we can double check that all the code getting merged is meeting the quality standards moving forward, so either one of us will review each PR going forward 👀

@sketchydroide sketchydroide marked this pull request as draft September 14, 2020 10:28
@sketchydroide
Copy link
Contributor Author

the GH for this has been closed, as @tgolen changes to Ion seem to have fixed the issue.

@roryabraham roryabraham deleted the afonseca_pusher_undefined_authtoken branch June 8, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants