-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix optimistic duplicate expense merge #45961
Conversation
I submitted two duplicate expenses, however, I don't see the "Review duplicates" button, @roryabraham please can you see where I'm missing? Thanks. Screen.Recording.2024-07-23.at.15.51.28.movI see an error within each theard preview, but I don't get the red dots in the LHN and I also don't see the "Review duplicates" button anywhere. I'm using a new account. |
It's behind a beta, maybe that's it? Are you testing on staging or dev? try on dev where all betas should be enabled by default |
I tested on staging, on my lastest dev main and your branch, all the same result. Maybe do I need a whitelist or something? This week I had to test a Stage Intact connection, the internal asked my email so can whitelist for beta feats. If yes my email is |
thanks @brunovjk, added [email protected] to the beta, though it may take up to an hour to take effect |
This comment was marked as resolved.
This comment was marked as resolved.
Reviewer Checklist
Screenshots/VideosAndroid: Native45961_android_native.movAndroid: mWeb Chrome45961_android_mweb.moviOS: Native45961_ios_native.moviOS: mWeb Safari45961_ios_mweb.movMacOS: Chrome / Safari45961_web_chorme.movMacOS: Desktop45961_desktop.mov |
@roryabraham It is flashing a 'not found' after confirming. Do you reproduce too? Thanks. web:Screen.Recording.2024-07-24.at.11.20.01.movios_native:Screen.Recording.2024-07-24.at.12.24.06.mov |
@brunovjk I didn't see that locally, but I'd wager it's not caused by these changes and likely would be reproducible on main as well. Try leaving the categories alone when creating the duplicate expenses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merge, please mind this comment
@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.14-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀
|
Details
This PR addresses two problems with the optimistic dupe detection code:
Fixed Issues
$ #45917
Tests / Offline Tests/ QA Steps
Resolve Duplicates
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov
MacOS: Desktop