Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple chat reports picked for onboarding #45785

Merged
merged 3 commits into from
Aug 1, 2024
Merged

fix: multiple chat reports picked for onboarding #45785

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3624a4a
fix: multiple chat reports picked for onboarding
pac-guerreiro Jul 19, 2024
370c28b
Merge branch 'main' into pac-guerreiro/fix/multiple-chat-reports-pick…
pac-guerreiro Jul 29, 2024
57091ea
fix: apply suggestions
pac-guerreiro Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7089,8 +7089,8 @@ function shouldShowMerchantColumn(transactions: Transaction[]) {
*/
function isChatUsedForOnboarding(optionOrReport: OnyxEntry<Report> | OptionData): boolean {
// onboarding can be an array for old accounts and accounts created from olddot
if (!Array.isArray(onboarding) && onboarding?.chatReportID === optionOrReport?.reportID) {
return true;
if (onboarding && !Array.isArray(onboarding) && onboarding.chatReportID && optionOrReport?.chatReportID) {
chiragsalian marked this conversation as resolved.
Show resolved Hide resolved
return onboarding.chatReportID === optionOrReport.chatReportID;
pac-guerreiro marked this conversation as resolved.
Show resolved Hide resolved
}

return AccountUtils.isAccountIDOddNumber(currentUserAccountID ?? -1)
Expand Down
Loading