Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Show positive amount when manually entering tax amount #45050

Merged
merged 2 commits into from
Jul 11, 2024
Merged

fix: Show positive amount when manually entering tax amount #45050

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d1ade1
Dispaly a positive tax amount when BE returns negative amount
etCoderDysto Jul 9, 2024
3ce2a72
Undo edited comment
etCoderDysto Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/MoneyRequestConfirmationListFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,9 @@ function MoneyRequestConfirmationListFooter({
const shouldShowBillable = policy?.disabledFields?.defaultBillable === false;
// Do not hide fields in case of paying someone
const shouldShowAllFields = !!isDistanceRequest || shouldExpandFields || !shouldShowSmartScanFields || isTypeSend || !!isEditingSplitBill;
// Calculate the formatted tax amount based on the transaction's tax amount and the IOU currency code
const formattedTaxAmount = CurrencyUtils.convertToDisplayString(transaction?.taxAmount, iouCurrencyCode);
// Calculate the formatted tax amount based on the transaction's tax amount returned from getTaxAmount and the IOU currency code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment update necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the existing comment is enough. I will undo the change.

Copy link
Contributor Author

@etCoderDysto etCoderDysto Jul 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the comment to its previous version.

const taxAmount = TransactionUtils.getTaxAmount(transaction, false);
const formattedTaxAmount = CurrencyUtils.convertToDisplayString(taxAmount, iouCurrencyCode);
// Get the tax rate title based on the policy and transaction
const taxRateTitle = TransactionUtils.getTaxName(policy, transaction);
// Determine if the merchant error should be displayed
Expand Down
Loading