Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change high resolution image with preview #44807

Merged
merged 52 commits into from
Jul 15, 2024
Merged

Change high resolution image with preview #44807

merged 52 commits into from
Jul 15, 2024

Commits on Jun 26, 2024

  1. Update version to 9.0.2-1 

    (cherry picked from commit ba6e2be)
    @OSBotify
    OSBotify committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    751f540 View commit details
    Browse the repository at this point in the history

  2. Merge pull request Expensify#44444 from software-mansion-labs/fix/lin… 

    …k-to-without-central-pane

Fix navigating between CentralPane screens

(cherry picked from commit f757005)
    @luacmartins @OSBotify
    luacmartins authored and OSBotify committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d7542be View commit details
    Browse the repository at this point in the history

  3. Update version to 9.0.2-2 

    (cherry picked from commit f1f472a)
    @OSBotify
    OSBotify committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    98e5373 View commit details
    Browse the repository at this point in the history

  4. Merge pull request Expensify#44505 from Expensify/yuwen-fixSplitSelec… 

    …tion

[CP Staging] Fix selection for splits when there is a search term present

(cherry picked from commit 47fafdb)
    @yuwenmemon @OSBotify
    yuwenmemon authored and OSBotify committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    20f13e8 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Update version to 9.0.2-3 

    (cherry picked from commit 050641a)
    @OSBotify
    OSBotify committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    d6c5cc5 View commit details
    Browse the repository at this point in the history

  2. Merge pull request Expensify#44508 from etCoderDysto/fixHold 

    fix: Hold option appears for invoice
(cherry picked from commit 6ea15ed)
    @carlosmiceli @OSBotify
    carlosmiceli authored and OSBotify committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    75d4ce9 View commit details
    Browse the repository at this point in the history

  3. Change big image preview to thumbnail

    @wildan-m
    wildan-m committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    7076b54 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Move hi Res image caption to attachment modal, change local upload be… 

    …havior
    @wildan-m
    wildan-m committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    012de0a View commit details
    Browse the repository at this point in the history

  2. fix isHiResImage logic

    @wildan-m
    wildan-m committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    8832aad View commit details
    Browse the repository at this point in the history

  3. change isUsedInAttachmentModal to isUploaded for more accurate result

    @wildan-m
    wildan-m committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    26d983a View commit details
    Browse the repository at this point in the history

  4. Add info icon to hi res image text

    @wildan-m
    wildan-m committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    3cdd20b View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi… 

    …x/38180-change-big-image-with-preview
    @wildan-m
    wildan-m committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    aa6b459 View commit details
    Browse the repository at this point in the history

  2. Refactor, remove unnecessary code

    @wildan-m
    wildan-m committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    04472fe View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Remove redundant log, resolve typescript error

    @wildan-m
    wildan-m committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f48e435 View commit details
    Browse the repository at this point in the history

  2. Add attachmentImageResized localization

    @wildan-m
    wildan-m committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    440fa48 View commit details
    Browse the repository at this point in the history

  3. prettier, refactor

    @wildan-m
    wildan-m committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    baf2452 View commit details
    Browse the repository at this point in the history

  4. replace rn text to custom text, remove unnecessary code, fix lint error.

    @wildan-m
    wildan-m committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    79bcfb5 View commit details
    Browse the repository at this point in the history

  5. Fix bug multiple attachments

    @wildan-m
    wildan-m committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    72e0409 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Fix crash on ios when tapping arrow on hi res to standard resolution … 

    …image
    @wildan-m
    wildan-m committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a8d61d9 View commit details
    Browse the repository at this point in the history

  2. Run prettier, fix lint

    @wildan-m
    wildan-m committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    6dafdc6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi… 

    …x/38180-change-big-image-with-preview
    @wildan-m
    wildan-m committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    c67aa8a View commit details
    Browse the repository at this point in the history

  4. lint

    @wildan-m
    wildan-m committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    1acae72 View commit details
    Browse the repository at this point in the history

  5. Add comment to explain why using isAttachmentCarouselScrolling to del… 

    …ay toggling modal footer
    @wildan-m
    wildan-m committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    8ca81d8 View commit details
    Browse the repository at this point in the history

  6. add attachmentTooLarge text

    @wildan-m
    wildan-m committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f5bc3da View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. restore safeAreaPaddingBottomStyle

    @wildan-m
    wildan-m committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7208d5f View commit details
    Browse the repository at this point in the history

  2. Refine setIsHighResolutionImage, DRY, remove unnecessary code

    @wildan-m
    wildan-m committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    28f74b1 View commit details
    Browse the repository at this point in the history

  3. revert accidentally commited code

    @wildan-m
    wildan-m committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b8d9717 View commit details
    Browse the repository at this point in the history

  4. revert code xcode files

    @wildan-m
    wildan-m committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    25c372f View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary code

    @wildan-m
    wildan-m committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    9a42575 View commit details
    Browse the repository at this point in the history

  6. Add comment for previewSource type

    @wildan-m
    wildan-m committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    53eda87 View commit details
    Browse the repository at this point in the history

  7. Fix the gap between text and button too wide in native

    @wildan-m
    wildan-m committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    314f738 View commit details
    Browse the repository at this point in the history

  8. run prettier

    @wildan-m
    wildan-m committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1e94322 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi… 

    …x/38180-change-big-image-with-preview
    @wildan-m
    wildan-m committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a017066 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Revise attachmentImageTooLarge spanish translation

    @wildan-m
    wildan-m committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    208180d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi… 

    …x/38180-change-big-image-with-preview
    @wildan-m
    wildan-m committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3e3edf9 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. prevent unnecessary change, rephrase comment

    @wildan-m
    wildan-m committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    4bf5652 View commit details
    Browse the repository at this point in the history

  2. revert attachment modal

    @wildan-m
    wildan-m committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    4daaae2 View commit details
    Browse the repository at this point in the history

  3. add value to isUploaded, move HighResolutionInfo to AttachmentView

    @wildan-m
    wildan-m committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    8698b5c View commit details
    Browse the repository at this point in the history

  4. Adjust IMAGE_HIGH_RESOLUTION_THRESHOLD

    @wildan-m
    wildan-m committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    50b7428 View commit details
    Browse the repository at this point in the history

  5. Merge

    @wildan-m
    wildan-m committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    b7e8ec4 View commit details
    Browse the repository at this point in the history

  6. remove unnecessary code

    @wildan-m
    wildan-m committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d61979a View commit details
    Browse the repository at this point in the history

  7. remove unnecessary code

    @wildan-m
    wildan-m committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1b698e8 View commit details
    Browse the repository at this point in the history

  8. run prettier

    @wildan-m
    wildan-m committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    8444da1 View commit details
    Browse the repository at this point in the history

  9. Refactor HighResolutionInfo

    @wildan-m
    wildan-m committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    dbd211a View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi… 

    …x/38180-change-big-image-with-preview
    @wildan-m
    wildan-m committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    66a807b View commit details
    Browse the repository at this point in the history

  11. Revert unnecessary change

    @wildan-m
    wildan-m committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d67066a View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Adjust high resolution info padding

    @wildan-m
    wildan-m committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c34b47f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi… 

    …x/38180-change-big-image-with-preview
    @wildan-m
    wildan-m committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    3534200 View commit details
    Browse the repository at this point in the history

  3. run prettier

    @wildan-m
    wildan-m committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    bba81bd View commit details
    Browse the repository at this point in the history

  4. fix isHighResolutionImage

    @wildan-m
    wildan-m committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    78ac528 View commit details
    Browse the repository at this point in the history

  5. re-adjust vertical padding highResolutionInfoPadding

    @wildan-m
    wildan-m committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4c23e80 View commit details
    Browse the repository at this point in the history

  6. fix highresolutioninfo padding

    @wildan-m
    wildan-m committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    fa37c50 View commit details
    Browse the repository at this point in the history