fix: Android - Map pending text shown in preview instead of icon #44187

Krishna2323 · 2024-06-21T21:57:50Z

Details

Fixed Issues

$ #43420
PROPOSAL: #43420 (comment)

Tests

precondition: user a member of a workspace

Android specific issue

Open the workspace chat
Create more than 1 distance expenses
In preview, verify the map pending text is not shown only the pending icon is shown with correct style.

Verify that no errors appear in the JS console

Offline tests

precondition: user a member of a workspace

Android specific issue

Open the workspace chat
Create more than 1 distance expenses
In preview, verify the map pending text is not shown only the pending icon is shown with correct style.

QA Steps

precondition: user a member of a workspace

Android specific issue

Open the workspace chat
Create more than 1 distance expenses
In preview, verify the map pending text is not shown only the pending icon is shown with correct style.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chroem.mp4

MacOS: Desktop

desktop_app.mp4

…ating > 1 expenses. Signed-off-by: Krishna Gupta <[email protected]>

Signed-off-by: Krishna Gupta <[email protected]>

melvin-bot · 2024-06-21T21:57:55Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ikevin127 · 2024-06-21T22:17:36Z

src/components/ConfirmedRoute.tsx

@@ -104,6 +104,7 @@ function ConfirmedRoute({mapboxAccessToken, transaction, isSmallerIcon, shouldHa

    const shouldDisplayMap = !requireRouteToDisplayMap || !!coordinates.length;

+    console.log(requireRouteToDisplayMap);


I think we don't need this anymore.

yes we don't need this anymore, thanks for the catch, removed. Recordings will be ready in a hour.

Signed-off-by: Krishna Gupta <[email protected]>

ikevin127 · 2024-06-22T00:55:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Online	Offline
android.webm	android-offline.webm

Android: mWeb Chrome

android-mweb.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ikevin127

Looks good on both light and dark theme and both online and offline flows, eactly as agreed upon the expected result with the design team 🎉

Notes for QA

The changes from this PR are only noticeable on Android: Native (platform specific fix).
The expected result agreed upon with the design team is correct, not the one from the issue's description.

OSBotify · 2024-06-23T00:11:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-25T20:10:34Z

🚀 Deployed to staging by https://github.com/francoisl in version: 9.0.2-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ikevin127 · 2024-07-02T20:22:37Z

@francoisl Looks like this PR was skipped from the production deploy for the past 7 days, any idea why ?

francoisl · 2024-07-02T20:50:18Z

Looks like the last production deploy failed. Going to check with the rest of the team.

https://github.com/Expensify/App/actions/runs/9704167915/job/26783866816

OSBotify · 2024-07-03T19:40:12Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T10:59:11Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Krishna2323 added 6 commits June 18, 2024 09:44

fix: Distance - Map pending not scaled and not fully visible when cre…

0f36464

…ating > 1 expenses. Signed-off-by: Krishna Gupta <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/43420

924d0e2

use requireRouteToDisplayMap prop.

a38fd79

Signed-off-by: Krishna Gupta <[email protected]>

fix pending map styling issue.

79fa0cd

Signed-off-by: Krishna Gupta <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/43420

959df8b

add comment.

5072173

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 requested a review from a team as a code owner June 21, 2024 21:57

melvin-bot bot removed the request for review from a team June 21, 2024 21:57

melvin-bot bot requested a review from ikevin127 June 21, 2024 21:57

Krishna2323 changed the title ~~fix: Distance - Map pending not scaled and not fully visible when creating > 1 expenses~~ fix: Android - Map pending text shown in preview instead of icon Jun 21, 2024

ikevin127 reviewed Jun 21, 2024

View reviewed changes

remove console.log

ae45b46

Signed-off-by: Krishna Gupta <[email protected]>

ikevin127 approved these changes Jun 22, 2024

View reviewed changes

melvin-bot bot requested a review from francoisl June 22, 2024 00:56

francoisl approved these changes Jun 23, 2024

View reviewed changes

francoisl merged commit 4dc1710 into Expensify:main Jun 23, 2024
15 of 17 checks passed

github-actions bot mentioned this pull request Jun 25, 2024

Deploy Checklist: New Expensify 2024-06-25 #44406

Closed

92 tasks

melvin-bot bot mentioned this pull request Jul 3, 2024

[HOLD for payment 2024-07-10] [$250] Distance - Map pending not scaled and not fully visible when creating > 1 expenses #43420

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Android - Map pending text shown in preview instead of icon #44187

fix: Android - Map pending text shown in preview instead of icon #44187

Krishna2323 commented Jun 21, 2024 •

edited

Loading

melvin-bot bot commented Jun 21, 2024

ikevin127 Jun 21, 2024

Krishna2323 Jun 21, 2024

ikevin127 commented Jun 22, 2024

ikevin127 left a comment

OSBotify commented Jun 23, 2024

OSBotify commented Jun 25, 2024

ikevin127 commented Jul 2, 2024

francoisl commented Jul 2, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 10, 2024

		@@ -104,6 +104,7 @@ function ConfirmedRoute({mapboxAccessToken, transaction, isSmallerIcon, shouldHa

		const shouldDisplayMap = !requireRouteToDisplayMap \|\| !!coordinates.length;

		console.log(requireRouteToDisplayMap);

fix: Android - Map pending text shown in preview instead of icon #44187

fix: Android - Map pending text shown in preview instead of icon #44187

Conversation

Krishna2323 commented Jun 21, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 21, 2024

ikevin127 Jun 21, 2024

Choose a reason for hiding this comment

Krishna2323 Jun 21, 2024

Choose a reason for hiding this comment

ikevin127 commented Jun 22, 2024

Reviewer Checklist

Screenshots/Videos

ikevin127 left a comment

Choose a reason for hiding this comment

Notes for QA

OSBotify commented Jun 23, 2024

OSBotify commented Jun 25, 2024

ikevin127 commented Jul 2, 2024

francoisl commented Jul 2, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 10, 2024

Krishna2323 commented Jun 21, 2024 •

edited

Loading