-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed task description when edit second time 42660 #43084
Fixed task description when edit second time 42660 #43084
Conversation
… description for second time
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Checking now. Sorry I was OOO for sometime. |
@abdulrahuman5196 have you been able to check this one? |
Hi, @samilabud Sorry for the delay. This PR missed my radar somehow. |
Done! Please take a look and let me know if there's anything else. 🙏🏼 |
Checking in, what happened with this PR @samilabud? |
Hi, @carlosmiceli sorry for the delay. Working on the review. Will close out in a day |
This comment was marked as outdated.
This comment was marked as outdated.
Hi @samilabud , I have tested all platforms except ios native, which I can only test on real device due to a setup issue currently. Could you kindly merge from main, so that I can ask internal engineer for adhoc build? |
Done! @abdulrahuman5196 (it is merged) |
Hi, @carlosmiceli Could you kindly add the Ready to build label for adhoc builds? So that I could test the ios native - #43084 (comment) |
@abdulrahuman5196 done! was that the right label? first time I'm using it :P |
@carlosmiceli Seems the right label, but didn't work for some reason. Asked in slack. https://expensify.slack.com/archives/C02NK2DQWUX/p1722235584168349 |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-07-24.at.12.23.24.AM.mp4Android: mWeb ChromeScreen.Recording.2024-07-24.at.12.35.18.AM.mp4iOS: NativeScreenRecording.moviOS: mWeb SafariScreen.Recording.2024-07-24.at.12.21.09.AM.mp4MacOS: Chrome / SafariScreen.Recording.2024-07-24.at.12.06.00.AM.mp4MacOS: DesktopScreen.Recording.2024-07-24.at.12.16.36.AM.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @carlosmiceli
🎀 👀 🎀
C+ Reviewed
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.14-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀
|
Details
Edited Task - Error occurs when description content exceed the 500 characters after parsed as html.
This error occurs when description content exceed the 500 characters after parsed as html in getParsedComment(), when we parse the description to HTML format using getParsedComment(). This happens because we validate the limit of 500 characters when it is single text strings, but we send it to the server after parsed, we notice the error when we are near the limit of 500 and the getParsedComment() returns converted the lines breaks to
<br />
, because this increase the text 5 characters for every line break.Fixed Issues
$ #42660
PROPOSAL: #42660 (comment)
Tests
Text to test:
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent placerat consectetur enim sit amet sodales. Etiam elementum, lorem id sollicitudin dignissim, quam nibh sodales arcu, imperdiet consequat risus mi sit amet lorem. Donec iaculis at tortor eget vulputate. Duis dignissim non diam id mattis. Suspendisse sit amet consequat elit, feugiat mattis libero. In hendrerit dui ac ante hendrerit condimentum nec
ddddDonec tellus odio, tristique non hendrerit quis, scelerisque placerat odio.
Offline tests
QA Steps
Text to test:
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent placerat consectetur enim sit amet sodales. Etiam elementum, lorem id sollicitudin dignissim, quam nibh sodales arcu, imperdiet consequat risus mi sit amet lorem. Donec iaculis at tortor eget vulputate. Duis dignissim non diam id mattis. Suspendisse sit amet consequat elit, feugiat mattis libero. In hendrerit dui ac ante hendrerit condimentum nec
ddddDonec tellus odio, tristique non hendrerit quis, scelerisque placerat odio.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android.Native.Task.long.description.validation.-.test.mov
Android: mWeb Chrome
Android.Chrome.Task.long.description.validation.-.test.mov
iOS: Native
IOS.Native.Task.long.description.validation.-.test.mov
iOS: mWeb Safari
IOS.Safari.Native.Task.long.description.validation.-.test.mov
MacOS: Chrome / Safari
MAC-Chrome.Task.long.description.validation.-.test.mov
MacOS: Desktop
Desktop.Task.long.description.validation.-.test.mov