Fix bug with The close button linked to "Request money. Get $250" is not functioning #36068

ZhenjaHorbach · 2024-02-07T19:32:26Z

Details

Fixed Issues

$ #36032
PROPOSAL: #36032 (comment)

Tests

Tap on the FAB
Select "Request money" manually.
Add the desired amount.
Verify that the Close button at the bottom of the modal linked with "Request money, $250" works as expected

Verify that no errors appear in the JS console

Offline tests

Tap on the FAB
Select "Request money" manually.
Add the desired amount.
Verify that the Close button at the bottom of the modal linked with "Request money, $250" works as expected

QA Steps

Tap on the FAB
Select "Request money" manually.
Add the desired amount.
Verify that the Close button at the bottom of the modal linked with "Request money, $250" works as expected

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-07.at.21.11.11.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…not functioning

melvin-bot · 2024-02-07T19:32:31Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-02-07T19:33:52Z

@cristipaval
PR is ready
And now I am working on videos

cristipaval · 2024-02-07T19:44:00Z

COuld you please take care of the lint errors?

ZhenjaHorbach · 2024-02-07T19:45:33Z

COuld you please take care of the lint errors?

Yeah
I noticed
Done )

s77rt · 2024-02-07T20:03:06Z

src/components/OptionsSelector/BaseOptionsSelector.js

@@ -41,9 +41,6 @@ const propTypes = {
    /** Whether referral CTA should be displayed */
    shouldShowReferralCTA: PropTypes.bool,

-    /** A method triggered when the user closes the call to action banner */
-    onCallToActionClosed: PropTypes.func,


Remove the default value too (defaultProps)

s77rt · 2024-02-07T20:05:10Z

src/components/OptionsSelector/BaseOptionsSelector.js

@@ -653,12 +644,9 @@ class BaseOptionsSelector extends Component {
                        </>
                    )}
                </View>
-                {this.props.shouldShowReferralCTA && this.state.shouldShowReferralModal && (
+                {this.props.shouldShowReferralCTA && (


Remove shouldShowReferralCTA prop. Instead use !dismissedReferralBanners(this.props.referralContentType)

I'm actually not sure about this
Because we will have to pass dismissedReferralBanners as a parameter
And it turns out that we are changing one thing for another

Actually ignore this comment. I think it's better to keep BaseOptionsSelector onyx-free

s77rt · 2024-02-07T20:06:40Z

src/components/OptionsSelector/BaseOptionsSelector.js

-    closeReferralModal() {
-        this.setState((prevState) => ({shouldShowReferralModal: !prevState.shouldShowReferralModal}));
-        this.props.onCallToActionClosed(this.props.referralContentType);
-    }
-


There is a leftover

this.closeReferralModal = this.closeReferralModal.bind(this);

This should be removed

ZhenjaHorbach · 2024-02-07T20:22:01Z

@s77rt
I hope everything is done))
And PR is ready )

s77rt · 2024-02-07T20:32:33Z

@ZhenjaHorbach Please fix the tests. The tests should state that after pressing the close button the user should Verify that the refer modal is closed

ZhenjaHorbach · 2024-02-07T20:35:39Z

@ZhenjaHorbach Please fix the tests. The tests should state that after pressing the close button the user should Verify that the refer modal is closed

As far as I understand
Tests passed successfully
And what is logical
In theory, they should have already been fixed in the previous ticket related Request money.

s77rt · 2024-02-07T20:38:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

s77rt · 2024-02-07T20:40:28Z

@ZhenjaHorbach I'm referring to the testing steps. Those steps are performed by the QA team and should clarify what to expect.

ZhenjaHorbach · 2024-02-07T20:42:15Z

Performance Tests

Sorry ))
I was thinking about unit tests))

ZhenjaHorbach · 2024-02-07T20:44:25Z

@ZhenjaHorbach I'm referring to the testing steps. Those steps are performed by the QA team and should clarify what to expect.

Done )

s77rt · 2024-02-07T20:44:58Z

Thank you!

s77rt · 2024-02-07T20:49:56Z

@ZhenjaHorbach Please change last step to:

Verify that the Close button at the bottom of the modal linked with "Request money, $250" works as expected

I think this is clear enough as the rest of the sentence may appear to be referring to the RHP modal

OSBotify · 2024-02-07T21:06:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…equest-money-is-not-functioning Fix bug with The close button linked to "Request money. Get $250" is not functioning (cherry picked from commit 8da7fe5)

OSBotify · 2024-02-07T21:43:04Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 1.4.38-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-08T18:22:21Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.38-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix bug with The close button linked to "Request money. Get $250" is …

2df92a1

…not functioning

ZhenjaHorbach requested a review from a team as a code owner February 7, 2024 19:32

melvin-bot bot requested review from s77rt and removed request for a team February 7, 2024 19:32

Update useMemo dependencies

a2a2c85

Fix prettier issue

b65b3a8

s77rt suggested changes Feb 7, 2024

View reviewed changes

Fix comments

42db1fc

s77rt approved these changes Feb 7, 2024

View reviewed changes

melvin-bot bot requested a review from cristipaval February 7, 2024 20:50

cristipaval approved these changes Feb 7, 2024

View reviewed changes

cristipaval merged commit 8da7fe5 into Expensify:main Feb 7, 2024
18 checks passed

github-actions bot mentioned this pull request Feb 7, 2024

Deploy Checklist: New Expensify 2024-02-07 #35983

Closed

49 tasks

cristipaval mentioned this pull request Feb 8, 2024

[$500] [HOLD for payment 2024-02-19] [HOLD for payment 2024-02-15] Request Money - The close button linked to "Request money. Get $250" is not functioning #36032

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bug with The close button linked to "Request money. Get $250" is not functioning #36068

Fix bug with The close button linked to "Request money. Get $250" is not functioning #36068

ZhenjaHorbach commented Feb 7, 2024 •

edited

Loading

melvin-bot bot commented Feb 7, 2024

ZhenjaHorbach commented Feb 7, 2024

cristipaval commented Feb 7, 2024

ZhenjaHorbach commented Feb 7, 2024

s77rt Feb 7, 2024

s77rt Feb 7, 2024

ZhenjaHorbach Feb 7, 2024 •

edited

Loading

s77rt Feb 7, 2024

s77rt Feb 7, 2024

ZhenjaHorbach commented Feb 7, 2024

s77rt commented Feb 7, 2024

ZhenjaHorbach commented Feb 7, 2024 •

edited

Loading

s77rt commented Feb 7, 2024 •

edited

Loading

s77rt commented Feb 7, 2024

ZhenjaHorbach commented Feb 7, 2024

ZhenjaHorbach commented Feb 7, 2024

s77rt commented Feb 7, 2024

s77rt commented Feb 7, 2024

OSBotify commented Feb 7, 2024

OSBotify commented Feb 7, 2024

OSBotify commented Feb 8, 2024

Fix bug with The close button linked to "Request money. Get $250" is not functioning #36068

Fix bug with The close button linked to "Request money. Get $250" is not functioning #36068

Conversation

ZhenjaHorbach commented Feb 7, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 7, 2024

ZhenjaHorbach commented Feb 7, 2024

cristipaval commented Feb 7, 2024

ZhenjaHorbach commented Feb 7, 2024

s77rt Feb 7, 2024

Choose a reason for hiding this comment

s77rt Feb 7, 2024

Choose a reason for hiding this comment

ZhenjaHorbach Feb 7, 2024 • edited Loading

Choose a reason for hiding this comment

s77rt Feb 7, 2024

Choose a reason for hiding this comment

s77rt Feb 7, 2024

Choose a reason for hiding this comment

ZhenjaHorbach commented Feb 7, 2024

s77rt commented Feb 7, 2024

ZhenjaHorbach commented Feb 7, 2024 • edited Loading

s77rt commented Feb 7, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

s77rt commented Feb 7, 2024

ZhenjaHorbach commented Feb 7, 2024

ZhenjaHorbach commented Feb 7, 2024

s77rt commented Feb 7, 2024

s77rt commented Feb 7, 2024

OSBotify commented Feb 7, 2024

OSBotify commented Feb 7, 2024

OSBotify commented Feb 8, 2024

ZhenjaHorbach commented Feb 7, 2024 •

edited

Loading

ZhenjaHorbach Feb 7, 2024 •

edited

Loading

ZhenjaHorbach commented Feb 7, 2024 •

edited

Loading

s77rt commented Feb 7, 2024 •

edited

Loading