Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "20354 task assignees list refactor" #35659

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

cristipaval
Copy link
Contributor

Reverts #34978 because typecheck fails in main with it merged.

@cristipaval cristipaval self-assigned this Feb 2, 2024
@cristipaval cristipaval requested a review from a team as a code owner February 2, 2024 13:17
@melvin-bot melvin-bot bot requested review from jasperhuangg and removed request for a team February 2, 2024 13:18
Copy link

melvin-bot bot commented Feb 2, 2024

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mountiny mountiny merged commit 150e171 into main Feb 2, 2024
13 of 15 checks passed
@mountiny mountiny deleted the revert-34978-20354-task_assignees_list_refactor branch February 2, 2024 13:21
@melvin-bot melvin-bot bot added the Emergency label Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny mountiny removed the Emergency label Feb 2, 2024
@mountiny
Copy link
Contributor

mountiny commented Feb 2, 2024

Straight revert

@OSBotify
Copy link
Contributor

OSBotify commented Feb 2, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 5, 2024

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.36-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants