From cb77b60e2ca2689bc7011be5154fb2fa70d717c4 Mon Sep 17 00:00:00 2001 From: Someshwar Tripathi Date: Wed, 24 Jan 2024 13:48:14 +0530 Subject: [PATCH 1/4] Update tagOutOfPolicy violation copy We update the copy to use 'Tag' when tagName is not available --- src/languages/en.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/languages/en.ts b/src/languages/en.ts index 0a754a883d07..e8cdadd3c27a 100755 --- a/src/languages/en.ts +++ b/src/languages/en.ts @@ -2114,7 +2114,7 @@ export default { }, smartscanFailed: 'Receipt scanning failed. Enter details manually.', someTagLevelsRequired: 'Missing tag', - tagOutOfPolicy: ({tagName}: ViolationsTagOutOfPolicyParams) => `${tagName ?? ''} no longer valid`, + tagOutOfPolicy: ({tagName}: ViolationsTagOutOfPolicyParams) => `${tagName ?? 'Tag'} no longer valid`, taxAmountChanged: 'Tax amount was modified', taxOutOfPolicy: ({taxName}: ViolationsTaxOutOfPolicyParams) => `${taxName ?? ''} no longer valid`, taxRateChanged: 'Tax rate was modified', From e36610905b11f2f1df86a48a81cd1a70c8a20f44 Mon Sep 17 00:00:00 2001 From: Someshwar Tripathi Date: Wed, 24 Jan 2024 13:49:32 +0530 Subject: [PATCH 2/4] Update taxOutOfPolicy violation copy We update the copy to use 'Tax' when taxName is not available --- src/languages/en.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/languages/en.ts b/src/languages/en.ts index e8cdadd3c27a..6b8f56489903 100755 --- a/src/languages/en.ts +++ b/src/languages/en.ts @@ -2116,7 +2116,7 @@ export default { someTagLevelsRequired: 'Missing tag', tagOutOfPolicy: ({tagName}: ViolationsTagOutOfPolicyParams) => `${tagName ?? 'Tag'} no longer valid`, taxAmountChanged: 'Tax amount was modified', - taxOutOfPolicy: ({taxName}: ViolationsTaxOutOfPolicyParams) => `${taxName ?? ''} no longer valid`, + taxOutOfPolicy: ({taxName}: ViolationsTaxOutOfPolicyParams) => `${taxName ?? 'Tax'} no longer valid`, taxRateChanged: 'Tax rate was modified', taxRequired: 'Missing tax rate', }, From b68dee1f3b306ba6fe86e89fd2d076158cf04f9d Mon Sep 17 00:00:00 2001 From: Someshwar Tripathi Date: Wed, 7 Feb 2024 15:01:02 +0530 Subject: [PATCH 3/4] Update spanish translation for taxOutOfPolicy --- src/languages/es.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/languages/es.ts b/src/languages/es.ts index 3675d4b25eab..664efee1cba0 100644 --- a/src/languages/es.ts +++ b/src/languages/es.ts @@ -2641,7 +2641,7 @@ export default { someTagLevelsRequired: 'Falta etiqueta', tagOutOfPolicy: ({tagName}: ViolationsTagOutOfPolicyParams) => `La etiqueta ${tagName} ya no es válida`, taxAmountChanged: 'El importe del impuesto fue modificado', - taxOutOfPolicy: ({taxName}: ViolationsTaxOutOfPolicyParams) => `${taxName} ya no es válido`, + taxOutOfPolicy: ({taxName}: ViolationsTaxOutOfPolicyParams) => `${taxName ?? 'El impuesto'} ya no es válido`, taxRateChanged: 'La tasa de impuesto fue modificada', taxRequired: 'Falta la tasa de impuesto', }, From 8e04559b6358d14d51a6455eb983372164be14d3 Mon Sep 17 00:00:00 2001 From: Someshwar Tripathi Date: Fri, 9 Feb 2024 19:20:47 +0530 Subject: [PATCH 4/4] Update spanish translation for tagOutOfPolicy --- src/languages/es.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/languages/es.ts b/src/languages/es.ts index 9cc46cb2ced5..f61abda6cd4d 100644 --- a/src/languages/es.ts +++ b/src/languages/es.ts @@ -2662,7 +2662,7 @@ export default { }, smartscanFailed: 'No se pudo escanear el recibo. Introduce los datos manualmente', someTagLevelsRequired: 'Falta etiqueta', - tagOutOfPolicy: ({tagName}: ViolationsTagOutOfPolicyParams) => `La etiqueta ${tagName} ya no es válida`, + tagOutOfPolicy: ({tagName}: ViolationsTagOutOfPolicyParams) => `La etiqueta ${tagName ? `${tagName} ` : ''}ya no es válida`, taxAmountChanged: 'El importe del impuesto fue modificado', taxOutOfPolicy: ({taxName}: ViolationsTaxOutOfPolicyParams) => `${taxName ?? 'El impuesto'} ya no es válido`, taxRateChanged: 'La tasa de impuesto fue modificada',