Form Provider Refactor] BaseGetPhysicalCard followup #34147

kowczarz · 2024-01-09T14:39:06Z

Details

Fixed Issues

Tests

Go to Settings/Wallet.
(Optional)
On Web, add this mock data in browser console:

window.Onyx.merge(`cardList`, {
   234523452345: {
       key: '234523452345',
        cardID: 234523452345,
        state: 2,
        bank: 'Expensify Card',
        availableSpend: 10000,
        domainName: 'expensify.com',
        lastFourPAN: '2345',
        isVirtual: false,
        fraud: null,
    },
});

On remaining platforms, add this useEffect on WalletPage.js:

useEffect(() => {
        if (cardList[234523452345]) {
            return;
        }
        // eslint-disable-next-line rulesdir/prefer-actions-set-data
        Onyx.merge(`cardList`, {
            234523452345: {
                key: '234523452345',
                cardID: 234523452345,
                state: 2,
                bank: 'Expensify Card',
                availableSpend: 10000,
                domainName: 'expensify.com',
                lastFourPAN: '2345',
                isVirtual: false,
                fraud: null,
            },
        });
    }, [cardList]);

Click on the Expensify Card in the Assigned Cards section list.
On the Expensify Card page you're currently in, press the Get Physical Card button at the bottom of the page.
If you have filled your personal details before, you should be shown the confirmation page with the correct data already filled.
Otherwise, you'll be shown either the legal name, phone number or address steps until you have filled every single piece of data required.
Type wrong data to the input and press next, so the error will appear.
Check if paddings are correct.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-01-10T13:40:23Z

@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kowczarz · 2024-01-10T13:40:54Z

@luacmartins here are the followups you requested in #33360 (comment)

luacmartins

LGTM! @kowczarz can you update the test steps to make sure that we specifically check the styles since that's what we're changing in this PR?

luacmartins · 2024-01-10T16:28:12Z

Adding @rushatgabhane for review

rushatgabhane · 2024-01-10T16:43:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rushatgabhane

LGTM! @luacmartins

melvin-bot · 2024-01-10T16:53:00Z

🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #34264.

kowczarz · 2024-01-10T17:20:43Z

@luacmartins done ✅

OSBotify · 2024-01-10T17:26:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-11T09:59:46Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.24-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2024-01-15T11:41:06Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.24-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix wrong paddings

fda671c

kowczarz changed the title ~~Form Provider Refactor] BaseGetPhysicalCard~~ Form Provider Refactor] BaseGetPhysicalCard followup Jan 9, 2024

kowczarz added 2 commits January 10, 2024 13:03

Fix lint

c5654ad

Fix lint

680b45d

kowczarz marked this pull request as ready for review January 10, 2024 13:39

kowczarz requested a review from a team as a code owner January 10, 2024 13:39

melvin-bot bot requested review from thienlnam and removed request for a team January 10, 2024 13:40

luacmartins self-requested a review January 10, 2024 16:03

luacmartins approved these changes Jan 10, 2024

View reviewed changes

luacmartins requested a review from rushatgabhane January 10, 2024 16:28

luacmartins removed the request for review from thienlnam January 10, 2024 16:28

rushatgabhane approved these changes Jan 10, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Jan 10, 2024

[Hold for Payment 2024-01-22] Payment issue for E/App PR#34147 #34264

Closed

luacmartins merged commit 5eff19d into Expensify:main Jan 10, 2024
18 of 20 checks passed

github-actions bot mentioned this pull request Jan 11, 2024

Deploy Checklist: New Expensify 2024-01-11 #34327

Closed

54 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Form Provider Refactor] BaseGetPhysicalCard followup #34147

Form Provider Refactor] BaseGetPhysicalCard followup #34147

kowczarz commented Jan 9, 2024 •

edited

Loading

melvin-bot bot commented Jan 10, 2024

kowczarz commented Jan 10, 2024

luacmartins left a comment

luacmartins commented Jan 10, 2024

rushatgabhane commented Jan 10, 2024 •

edited

Loading

rushatgabhane left a comment

melvin-bot bot commented Jan 10, 2024

kowczarz commented Jan 10, 2024

OSBotify commented Jan 10, 2024

OSBotify commented Jan 11, 2024

OSBotify commented Jan 15, 2024

Form Provider Refactor] BaseGetPhysicalCard followup #34147

Form Provider Refactor] BaseGetPhysicalCard followup #34147

Conversation

kowczarz commented Jan 9, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 10, 2024

kowczarz commented Jan 10, 2024

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Jan 10, 2024

rushatgabhane commented Jan 10, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jan 10, 2024

kowczarz commented Jan 10, 2024

OSBotify commented Jan 10, 2024

OSBotify commented Jan 11, 2024

OSBotify commented Jan 15, 2024

kowczarz commented Jan 9, 2024 •

edited

Loading

rushatgabhane commented Jan 10, 2024 •

edited

Loading