[Form Provider Refactor] BaseGetPhysicalCard #33360

kowczarz · 2023-12-20T14:06:40Z

Details

Fixed Issues

Tests

Go to Settings/Wallet.
(Optional)
On Web, add this mock data in browser console:

window.Onyx.merge(`cardList`, {
   234523452345: {
       key: '234523452345',
        cardID: 234523452345,
        state: 2,
        bank: 'Expensify Card',
        availableSpend: 10000,
        domainName: 'expensify.com',
        lastFourPAN: '2345',
        isVirtual: false,
        fraud: null,
    },
});

On remaining platforms, add this useEffect on WalletPage.js:

useEffect(() => {
        if (cardList[234523452345]) {
            return;
        }
        // eslint-disable-next-line rulesdir/prefer-actions-set-data
        Onyx.merge(`cardList`, {
            234523452345: {
                key: '234523452345',
                cardID: 234523452345,
                state: 2,
                bank: 'Expensify Card',
                availableSpend: 10000,
                domainName: 'expensify.com',
                lastFourPAN: '2345',
                isVirtual: false,
                fraud: null,
            },
        });
    }, [cardList]);

Click on the Expensify Card in the Assigned Cards section list.
On the Expensify Card page you're currently in, press the Get Physical Card button at the bottom of the page.
If you have filled your personal details before, you should be shown the confirmation page with the correct data already filled.
Otherwise, you'll be shown either the legal name, phone number or address steps until you have filled every single piece of data required.
When all data is filled, you can press the Ship Card button on the confirmation step to go back to the Expensify Card page.
At this point, it's not possible to send the request to the API so the Expensify Card page won't show the updated state when you already requested the physical card.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native_H.265.mp4

Android: mWeb Chrome

android.web_H.265.mp4

iOS: Native

ios.native_H.265.mp4

iOS: mWeb Safari

ios.web_H.265.mp4

MacOS: Chrome / Safari

MacOS: Desktop

desktop_H.265.mp4

melvin-bot · 2023-12-20T14:06:45Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-12-21T13:52:30Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kowczarz · 2023-12-21T14:00:39Z

Cc. @luacmartins. I think it's the last Form.js usage in our codebase. As soon as we will merge this PR, we will be able to delete the mentioned file.

cdOut

LGTM!

kowczarz · 2023-12-22T09:49:47Z

Hello @rushatgabhane will you have some time to review this PR today?

rushatgabhane · 2023-12-26T04:01:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rushatgabhane · 2023-12-26T15:37:13Z

These comments are unrelated to PR but im mentioning them in case we aren't already aware of them :

@kowczarz

should we autofocus the phone number input?
Should we save the phone number draft when the number is invalid. Because you can input a wrong number, and go back. It'll save the draft.
Also, the design looks off. Do we plan to improve it in future PRs?

kowczarz · 2024-01-02T10:23:36Z

should we autofocus the phone number input?

I kept the logic from the original component

Should we save the phone number draft when the number is invalid. Because you can input a wrong number, and go back. It'll save the draft.

We can consider adding logic that prevents saving the draft when the field has an error. @luacmartins WDYT?

Also, the design looks off. Do we plan to improve it in future PRs?

I have no idea, maybe @luacmartins can say something more.

But anyway, I would like to merge the current PR, so we will be able to remove the old Form component, and then we can address non-blocking issues.

kowczarz · 2024-01-04T14:17:16Z

Bump @luacmartins

kowczarz · 2024-01-08T10:53:27Z

@luacmartins

luacmartins · 2024-01-08T15:54:24Z

Sorry, I was ooo until today.

We can consider adding logic that prevents saving the draft when the field has an error. @luacmartins WDYT?

I don't think this is necessary. It's up to the user to fix this when they are navigated to the page again.

Also, the design looks off. Do we plan to improve it in future PRs?

It seems like we have extra horizontal padding on the inputs. I'm ok with merging this PR to unblock removing the old Form component before we introduce another usage, but can we please create a follow up PR to fix the padding?

OSBotify · 2024-01-08T15:58:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-09T05:36:45Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.23-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-01-09T06:38:08Z

@rushatgabhane @luacmartins Can we skip the step 7 and 8?

luacmartins · 2024-01-09T16:35:24Z

@kavimuru yes, you can skip steps 7 and 8. Thanks for checking!

OSBotify · 2024-01-10T06:04:00Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.23-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Refactor get physical card flow

f0f3467

kowczarz marked this pull request as ready for review December 21, 2023 13:52

kowczarz requested a review from a team as a code owner December 21, 2023 13:52

melvin-bot bot removed the request for review from a team December 21, 2023 13:52

melvin-bot bot requested a review from rushatgabhane December 21, 2023 13:52

luacmartins approved these changes Dec 21, 2023

View reviewed changes

cdOut approved these changes Dec 21, 2023

View reviewed changes

rushatgabhane approved these changes Dec 26, 2023

View reviewed changes

melvin-bot bot requested a review from luacmartins December 26, 2023 15:50

filip-solecki approved these changes Dec 27, 2023

View reviewed changes

luacmartins merged commit 5aaeca1 into Expensify:main Jan 8, 2024
17 of 42 checks passed

github-actions bot mentioned this pull request Jan 9, 2024

Deploy Checklist: New Expensify 2024-01-09 #34121

Closed

87 tasks

kowczarz mentioned this pull request Jan 9, 2024

Form Provider Refactor] BaseGetPhysicalCard followup #34147

Merged

50 tasks

melvin-bot bot mentioned this pull request Jan 10, 2024

[Awaiting manual request payment] [$125] [Form Provider Refactor] BaseGetPhysicalCard #33356

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Form Provider Refactor] BaseGetPhysicalCard #33360

[Form Provider Refactor] BaseGetPhysicalCard #33360

kowczarz commented Dec 20, 2023 •

edited

Loading

melvin-bot bot commented Dec 20, 2023

melvin-bot bot commented Dec 21, 2023

kowczarz commented Dec 21, 2023

cdOut left a comment

kowczarz commented Dec 22, 2023

rushatgabhane commented Dec 26, 2023 •

edited

Loading

rushatgabhane commented Dec 26, 2023 •

edited

Loading

kowczarz commented Jan 2, 2024 •

edited

Loading

kowczarz commented Jan 4, 2024

kowczarz commented Jan 8, 2024

luacmartins commented Jan 8, 2024

OSBotify commented Jan 8, 2024

OSBotify commented Jan 9, 2024

kavimuru commented Jan 9, 2024

luacmartins commented Jan 9, 2024

OSBotify commented Jan 10, 2024

[Form Provider Refactor] BaseGetPhysicalCard #33360

[Form Provider Refactor] BaseGetPhysicalCard #33360

Conversation

kowczarz commented Dec 20, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 20, 2023

melvin-bot bot commented Dec 21, 2023

kowczarz commented Dec 21, 2023

cdOut left a comment

Choose a reason for hiding this comment

kowczarz commented Dec 22, 2023

rushatgabhane commented Dec 26, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane commented Dec 26, 2023 • edited Loading

kowczarz commented Jan 2, 2024 • edited Loading

kowczarz commented Jan 4, 2024

kowczarz commented Jan 8, 2024

luacmartins commented Jan 8, 2024

OSBotify commented Jan 8, 2024

OSBotify commented Jan 9, 2024

kavimuru commented Jan 9, 2024

luacmartins commented Jan 9, 2024

OSBotify commented Jan 10, 2024

kowczarz commented Dec 20, 2023 •

edited

Loading

rushatgabhane commented Dec 26, 2023 •

edited

Loading

rushatgabhane commented Dec 26, 2023 •

edited

Loading

kowczarz commented Jan 2, 2024 •

edited

Loading