-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FinancalForce.md #32890
Update FinancalForce.md #32890
Conversation
A preview of your ExpensifyHelp changes have been deployed to https://dd39bec2.helpdot.pages.dev ⚡️ |
Hi, @rushatgabhane, not exactly sure, I guess you're responsible for reviewing these help documents? 😂 |
Reviewer Checklist
|
Sorry @ntdiary 😬 - my bad! |
🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #33038. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Financial Force is now Certinia?! :chloe:
🚀 Deployed to staging by https://github.com/deetergp in version: 1.4.14-0 🚀
|
🚀 Deployed to staging by https://github.com/deetergp in version: 1.4.14-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.14-6 🚀
|
Details
Financial Force is now Certinia, also we left off the errors when this was created.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/341224
Tests
Go to https://help.expensify.com/articles/expensify-classic/integrations/accounting-integrations/FinancalForce and make sure that it says Certinia everywhere.
Offline tests
N/A
QA Steps
Go to https://help.expensify.com/articles/expensify-classic/integrations/accounting-integrations/FinancalForce and make sure that it says Certinia everywhere.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videosundefined