[TS migration] Migrate 'SingleOptionSelector.js' component to TypeScript #32660

pac-guerreiro · 2023-12-07T13:32:01Z

Details

N/A

Fixed Issues

$ #31946
PROPOSAL:
N/A

Tests

Go to Settings>Wallet
(OPTIONAL) Add mocked expensify card data like this:

useEffect(() => {
        if (cardList[234523452345]) {
            return;
        }
        // eslint-disable-next-line rulesdir/prefer-actions-set-data
        Onyx.merge(`cardList`, {
            234523452345: {
                key: '234523452345',
                cardID: 234523452345,
                state: 2,
                bank: 'Expensify Card',
                availableSpend: 10000,
                domainName: 'expensify.com',
                lastFourPAN: '2345',
                isVirtual: false,
                fraud: null,
            },
        });
}, [cardList]);

Select an Expensify card
Click on Report card lost or damaged
Check that you can only select one option

Offline tests

Same as Tests.

QA Steps

Same as Tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

blazejkustra

LGTM! Fill out tests section 😄

fabioh8010 · 2023-12-08T10:24:50Z

@pac-guerreiro Please let's add tests and screenshots.

…elector-to-typescript

melvin-bot · 2023-12-13T16:07:07Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…elector-to-typescript

pac-guerreiro · 2023-12-13T16:38:04Z

@fabioh8010 tests and screenshots added! 😄

rushatgabhane · 2023-12-15T14:01:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-12-15T14:03:25Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #31946 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

rushatgabhane · 2023-12-15T14:05:22Z

Tested by fixing the merge conflict locally. (it's only an import conflict)

@pac-guerreiro please push a commit for fixing the merge conflict, thx!

…elector-to-typescript # Conflicts: # src/components/SingleOptionSelector.tsx

pac-guerreiro · 2023-12-18T16:02:36Z

@rushatgabhane Thanks for the heads up! Conflict resolved! 😄

OSBotify · 2023-12-18T18:56:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-19T02:43:30Z

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-19T03:46:51Z

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2023-12-19T05:06:01Z

@rushatgabhane @johnmlee101 @fabioh8010 Tried adding the card with the snippet and get an error. Is this testable in Staging?

pac-guerreiro · 2023-12-19T09:08:10Z

@mvtglobally

Sorry I should've provided better testing steps for QA. In your case, instead of using the useEffect, just write this on the console:

window.Onyx.merge("cardList", {
            234523452345: {
                key: '234523452345',
                cardID: 234523452345,
                state: 2,
                bank: 'Expensify Card',
                availableSpend: 10000,
                domainName: 'expensify.com',
                lastFourPAN: '2345',
                isVirtual: false,
                fraud: null,
            },
        });

isagoico · 2023-12-20T13:53:38Z

@pac-guerreiro Hi there - We're still unable to give a shot at this PR. Here's the error we're receiving in console
.

kavimuru · 2023-12-20T14:23:43Z

@pac-guerreiro we validated this PR using the account [email protected] account. Since this account has expensify card already.

OSBotify · 2023-12-21T05:14:26Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.14-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

JmillsExpensify · 2023-12-28T22:11:43Z

@johnmlee101 can I get a payment summary for this issue? @rushatgabhane is requesting payment.

johnmlee101 · 2024-01-02T15:30:10Z

Should just be a C+ payment for the PR review for @rushatgabhane

johnmlee101 · 2024-01-02T15:46:45Z

Payment summary:
~~- $500 payment to Rushat for PR Review and Testing~~

rushatgabhane · 2024-01-02T15:49:40Z

@johnmlee101 small correction TS migration is $250

johnmlee101 · 2024-01-02T15:59:01Z

Oh thank you, changing

Payment summary:

$250 payment to Rushat for PR Review and Testing

JmillsExpensify · 2024-01-02T18:45:56Z

$250 payment approved for @rushatgabhane based on comment above.

refactor(typescript): migrate singleoptionselector

acdb71b

blazejkustra approved these changes Dec 8, 2023

View reviewed changes

Merge branch 'main' into pac-guerreiro/refactor/migrate-singleoptions…

b656267

…elector-to-typescript

fabioh8010 approved these changes Dec 11, 2023

View reviewed changes

pac-guerreiro marked this pull request as ready for review December 13, 2023 16:07

pac-guerreiro requested a review from a team as a code owner December 13, 2023 16:07

melvin-bot bot requested review from rushatgabhane and removed request for a team December 13, 2023 16:07

Merge branch 'main' into pac-guerreiro/refactor/migrate-singleoptions…

3bb51af

…elector-to-typescript

rushatgabhane approved these changes Dec 15, 2023

View reviewed changes

melvin-bot bot requested a review from johnmlee101 December 15, 2023 14:03

Merge branch 'main' into pac-guerreiro/refactor/migrate-singleoptions…

8cd7767

…elector-to-typescript # Conflicts: # src/components/SingleOptionSelector.tsx

johnmlee101 approved these changes Dec 18, 2023

View reviewed changes

johnmlee101 merged commit c4659d6 into Expensify:main Dec 18, 2023
15 checks passed

github-actions bot mentioned this pull request Dec 19, 2023

Deploy Checklist: New Expensify 2023-12-19 #33264

Closed

98 tasks

melvin-bot bot mentioned this pull request Dec 21, 2023

[HOLD for payment 2023-12-28] [TS migration] Migrate 'SingleOptionSelector.js' component to TypeScript #31946

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'SingleOptionSelector.js' component to TypeScript #32660

[TS migration] Migrate 'SingleOptionSelector.js' component to TypeScript #32660

pac-guerreiro commented Dec 7, 2023 •

edited

Loading

blazejkustra left a comment •

edited

Loading

fabioh8010 commented Dec 8, 2023

melvin-bot bot commented Dec 13, 2023

pac-guerreiro commented Dec 13, 2023

rushatgabhane commented Dec 15, 2023 •

edited

Loading

melvin-bot bot commented Dec 15, 2023

rushatgabhane commented Dec 15, 2023

pac-guerreiro commented Dec 18, 2023

OSBotify commented Dec 18, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

mvtglobally commented Dec 19, 2023

pac-guerreiro commented Dec 19, 2023 •

edited

Loading

isagoico commented Dec 20, 2023

kavimuru commented Dec 20, 2023

OSBotify commented Dec 21, 2023

JmillsExpensify commented Dec 28, 2023

johnmlee101 commented Jan 2, 2024

johnmlee101 commented Jan 2, 2024 •

edited

Loading

rushatgabhane commented Jan 2, 2024 •

edited

Loading

johnmlee101 commented Jan 2, 2024

JmillsExpensify commented Jan 2, 2024

[TS migration] Migrate 'SingleOptionSelector.js' component to TypeScript #32660

[TS migration] Migrate 'SingleOptionSelector.js' component to TypeScript #32660

Conversation

pac-guerreiro commented Dec 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

blazejkustra left a comment • edited Loading

Choose a reason for hiding this comment

fabioh8010 commented Dec 8, 2023

melvin-bot bot commented Dec 13, 2023

pac-guerreiro commented Dec 13, 2023

rushatgabhane commented Dec 15, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Dec 15, 2023

rushatgabhane commented Dec 15, 2023

pac-guerreiro commented Dec 18, 2023

OSBotify commented Dec 18, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

mvtglobally commented Dec 19, 2023

pac-guerreiro commented Dec 19, 2023 • edited Loading

isagoico commented Dec 20, 2023

kavimuru commented Dec 20, 2023

OSBotify commented Dec 21, 2023

JmillsExpensify commented Dec 28, 2023

johnmlee101 commented Jan 2, 2024

johnmlee101 commented Jan 2, 2024 • edited Loading

rushatgabhane commented Jan 2, 2024 • edited Loading

johnmlee101 commented Jan 2, 2024

JmillsExpensify commented Jan 2, 2024

pac-guerreiro commented Dec 7, 2023 •

edited

Loading

blazejkustra left a comment •

edited

Loading

rushatgabhane commented Dec 15, 2023 •

edited

Loading

pac-guerreiro commented Dec 19, 2023 •

edited

Loading

johnmlee101 commented Jan 2, 2024 •

edited

Loading

rushatgabhane commented Jan 2, 2024 •

edited

Loading