Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved country search #32151

Closed
wants to merge 11 commits into from
Closed

Conversation

graylewis
Copy link
Contributor

@graylewis graylewis commented Nov 28, 2023

Details

This search improves the UX for country search in a few ways, namely by improving how diacritics and country codes are handled.

Fixed Issues

$ #29826
PROPOSAL: $ #29826 (comment)

Tests

  1. Run the unit tests that were created in this PR
  2. Test for diacritic prioritization: search for "Ål" and ensure that "Åland Islands" is the top result
  3. Search for "US" and ensure that the United States is the top result
  4. Search for "Bar" and ensure that "Barbados" is the top result

Offline tests

N/A

QA Steps

  1. Run the unit tests that were created in this PR
  2. Test for diacritic prioritization: search for "Ål" and ensure that "Åland Islands" is the top result
  3. Search for "US" and ensure that the United States is the top result
  4. Search for "Bar" and ensure that "Barbados" is the top result

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

(I'm unfortunately unable to get the android simulator running on my computer)

Android: mWeb Chrome

(I'm unfortunately unable to get the android simulator running on my computer)

iOS: Native
Screen.Recording.2023-12-03.at.3.52.26.PM.mov
iOS: mWeb Safari

Since switching the dev URL to https://dev.new.expensify.com/, the iOS simulator cannot access the website through safari (throws HTTPS error)

MacOS: Chrome / Safari
Screen.Recording.2023-11-28.at.5.24.04.PM.mov
MacOS: Desktop
Screen.Recording.2023-11-28.at.5.30.09.PM.mov

@graylewis graylewis marked this pull request as ready for review December 3, 2023 14:58
@graylewis graylewis requested a review from a team as a code owner December 3, 2023 14:58
@melvin-bot melvin-bot bot requested review from situchan and removed request for a team December 3, 2023 14:58
Copy link

melvin-bot bot commented Dec 3, 2023

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Even with expensify/main
@situchan
Copy link
Contributor

@graylewis please pull main

@graylewis graylewis force-pushed the improvedCountrySearch branch from efc352a to 5663a29 Compare January 25, 2024 16:06
@situchan
Copy link
Contributor

Still not synced with latest main

Screenshot 2024-01-28 at 8 14 44 PM

src/libs/searchCountryOptions.ts Show resolved Hide resolved
src/libs/searchCountryOptions.ts Show resolved Hide resolved
@situchan
Copy link
Contributor

BUG?: different sort between New/New (2 spaces) vs New (1 space)

bug.mov

@graylewis graylewis force-pushed the improvedCountrySearch branch from 401599e to 5663a29 Compare January 30, 2024 14:44
@situchan situchan mentioned this pull request Jan 30, 2024
48 tasks
@graylewis graylewis closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants