-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved country search #32151
Closed
Closed
Improved country search #32151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even with main
Even with expensify
Even with expensify/main
@graylewis please pull main |
situchan
reviewed
Jan 4, 2024
6 tasks
graylewis
force-pushed
the
improvedCountrySearch
branch
from
January 25, 2024 16:06
efc352a
to
5663a29
Compare
situchan
suggested changes
Jan 28, 2024
situchan
reviewed
Jan 28, 2024
BUG?: different sort between bug.mov |
graylewis
force-pushed
the
improvedCountrySearch
branch
from
January 30, 2024 14:44
401599e
to
5663a29
Compare
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This search improves the UX for country search in a few ways, namely by improving how diacritics and country codes are handled.
Fixed Issues
$ #29826
PROPOSAL: $ #29826 (comment)
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
(I'm unfortunately unable to get the android simulator running on my computer)
Android: mWeb Chrome
(I'm unfortunately unable to get the android simulator running on my computer)
iOS: Native
Screen.Recording.2023-12-03.at.3.52.26.PM.mov
iOS: mWeb Safari
Since switching the dev URL to https://dev.new.expensify.com/, the iOS simulator cannot access the website through safari (throws HTTPS error)
MacOS: Chrome / Safari
Screen.Recording.2023-11-28.at.5.24.04.PM.mov
MacOS: Desktop
Screen.Recording.2023-11-28.at.5.30.09.PM.mov