[TS migration] Migrate 'AutoUpdateTime.js' component to TypeScript #31521

BartoszGrajdek · 2023-11-19T14:21:15Z

Details

Migrate 'AutoUpdateTime.js' component file to TypeScript

Fixed Issues

$ #25020

Tests

Open somebody else's profile page i.e. through shared workspace
Check the local time
Wait 1 minute
Check if the timer was updated

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open somebody else's profile page i.e. through shared workspace
Check the local time
Wait 1 minute
Check if the timer was updated

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…ate-time-component

src/components/AutoUpdateTime.tsx

…ate-time-component

src/components/AutoUpdateTime.tsx

fabioh8010

Just a NAB, LGTM!

fabioh8010 · 2023-11-27T13:02:38Z

src/components/AutoUpdateTime.tsx

-        () => DateUtils.getLocalDateFromDatetime(props.preferredLocale, null, props.timezone.selected),
-        [props.preferredLocale, props.timezone.selected],
-    );
+    /** @returns Returns the locale Date object */


Suggested change

/** @returns Returns the locale Date object */

/** @returns Returns the locale Date object */

NAB

…ate-time-component

melvin-bot · 2023-12-11T19:11:08Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cubuspl42 · 2023-12-12T11:55:33Z

src/components/AutoUpdateTime.tsx

+        if (timezone.selected) {
+            return DateUtils.getZoneAbbreviation(currentUserLocalTime, timezone.selected);
+        }
+        return '';


Was this change inspired by a typing problem?

Yes, as getZoneAbbreviation expects that timezone is defined

cubuspl42 · 2023-12-12T11:56:36Z

The code looks good! Left a minor question. I'll get to testing.

cubuspl42 · 2023-12-12T15:52:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

auto-update-time-component-web.mp4

Mobile Web - Chrome

Mobile Web - Safari

auto-update-time-component-ios-web.mp4

Desktop

iOS

auto-update-time-component-ios.mp4

Android

auto-update-time-component-android-compressed.mp4

cubuspl42

Please merge main. Otherwise looks good 👍

blazejkustra · 2023-12-12T16:53:26Z

@cubuspl42 Done!

melvin-bot · 2023-12-13T10:15:59Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25020 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

deetergp

Code looks good, and the other user's time rolled from 8:36 am to 8:37 as advertised. 👍

deetergp · 2023-12-14T16:38:59Z

@BartoszGrajdek Sorry, but it looks like you've got a merge conflict. Once you pull main and resolve them, I'll approve again & merge. Thanks!

blazejkustra · 2023-12-14T16:58:07Z

@deetergp Done!

deetergp · 2023-12-14T18:21:40Z

Thanks @blazejkustra!

OSBotify · 2023-12-14T18:25:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-19T02:42:30Z

🚀 Deployed to staging by https://github.com/deetergp in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-19T03:45:51Z

🚀 Deployed to staging by https://github.com/deetergp in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-21T05:13:26Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.14-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

BartoszGrajdek added 4 commits October 20, 2023 14:16

Rename AutoUpdateTime

dda39ec

Merge remote-tracking branch 'origin/main' into ts-migration/auto-upd…

59ae8c5

…ate-time-component

[TS migration] Migrate 'AutoUpdateTime.js' component to TypeScript

01e00ec

fix: prettier

f1b3339

blazejkustra suggested changes Nov 20, 2023

View reviewed changes

src/components/AutoUpdateTime.tsx Outdated Show resolved Hide resolved

BartoszGrajdek added 2 commits November 23, 2023 12:26

Merge remote-tracking branch 'origin/main' into ts-migration/auto-upd…

2522433

…ate-time-component

fix: remove required<> from types

7770c89

blazejkustra suggested changes Nov 23, 2023

View reviewed changes

src/components/AutoUpdateTime.tsx Outdated Show resolved Hide resolved

src/components/AutoUpdateTime.tsx Outdated Show resolved Hide resolved

BartoszGrajdek added 3 commits November 23, 2023 12:59

Destructure props

bb6a916

fix: remove type from JSDoc

2ba4c7d

fix: spelling mistake

9254f76

blazejkustra approved these changes Nov 23, 2023

View reviewed changes

fabioh8010 approved these changes Nov 27, 2023

View reviewed changes

Merge remote-tracking branch 'origin/main' into ts-migration/auto-upd…

ca41e60

…ate-time-component

BartoszGrajdek marked this pull request as ready for review December 11, 2023 19:11

BartoszGrajdek requested a review from a team as a code owner December 11, 2023 19:11

melvin-bot bot requested review from cubuspl42 and removed request for a team December 11, 2023 19:11

cubuspl42 reviewed Dec 12, 2023

View reviewed changes

cubuspl42 suggested changes Dec 12, 2023

View reviewed changes

Merge branch 'main' into ts-migration/auto-update-time-component

3e8dd77

cubuspl42 approved these changes Dec 13, 2023

View reviewed changes

melvin-bot bot requested a review from deetergp December 13, 2023 10:16

deetergp previously approved these changes Dec 14, 2023

View reviewed changes

Merge branch 'main' into ts-migration/auto-update-time-component

4a78732

blazejkustra dismissed deetergp’s stale review via 4a78732 December 14, 2023 16:57

deetergp approved these changes Dec 14, 2023

View reviewed changes

deetergp merged commit 66ef49e into Expensify:main Dec 14, 2023
17 checks passed

github-actions bot mentioned this pull request Dec 19, 2023

Deploy Checklist: New Expensify 2023-12-19 #33264

Closed

98 tasks

melvin-bot bot mentioned this pull request Dec 21, 2023

[HOLD for payment 2023-12-28] [TS migration] Migrate 'AutoUpdateTime.js' component to TypeScript #25020

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'AutoUpdateTime.js' component to TypeScript #31521

[TS migration] Migrate 'AutoUpdateTime.js' component to TypeScript #31521

BartoszGrajdek commented Nov 19, 2023 •

edited

Loading

fabioh8010 left a comment

fabioh8010 Nov 27, 2023

melvin-bot bot commented Dec 11, 2023

cubuspl42 Dec 12, 2023

blazejkustra Dec 12, 2023

cubuspl42 commented Dec 12, 2023

cubuspl42 commented Dec 12, 2023

cubuspl42 left a comment

blazejkustra commented Dec 12, 2023

melvin-bot bot commented Dec 13, 2023

deetergp left a comment

deetergp commented Dec 14, 2023

blazejkustra commented Dec 14, 2023

deetergp commented Dec 14, 2023

OSBotify commented Dec 14, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 21, 2023

	/** @returns Returns the locale Date object */

	/** @returns Returns the locale Date object */

[TS migration] Migrate 'AutoUpdateTime.js' component to TypeScript #31521

[TS migration] Migrate 'AutoUpdateTime.js' component to TypeScript #31521

Conversation

BartoszGrajdek commented Nov 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

fabioh8010 left a comment

Choose a reason for hiding this comment

fabioh8010 Nov 27, 2023

Choose a reason for hiding this comment

melvin-bot bot commented Dec 11, 2023

cubuspl42 Dec 12, 2023

Choose a reason for hiding this comment

blazejkustra Dec 12, 2023

Choose a reason for hiding this comment

cubuspl42 commented Dec 12, 2023

cubuspl42 commented Dec 12, 2023

Reviewer Checklist

Screenshots/Videos

cubuspl42 left a comment

Choose a reason for hiding this comment

blazejkustra commented Dec 12, 2023

melvin-bot bot commented Dec 13, 2023

deetergp left a comment

Choose a reason for hiding this comment

deetergp commented Dec 14, 2023

blazejkustra commented Dec 14, 2023

deetergp commented Dec 14, 2023

OSBotify commented Dec 14, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 21, 2023

BartoszGrajdek commented Nov 19, 2023 •

edited

Loading