Update subscribe on leave #30812

srikarparsi · 2023-11-03T01:37:51Z

Details

Fixed Issues

$ #30546
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Test with this Auth PR

Comment in a room
.Reply in thread to that comment
Leave the thread report that you commented in
The subscribe icon should show up in the parent comment's action menu

Offline tests

QA Steps

Verify that no errors appear in the JS console

Same as Tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-11-16.at.4.11.58.AM.mov

MacOS: Desktop

merge main

melvin-bot · 2023-11-16T09:29:18Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-11-16T09:29:25Z

@ntdiary @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ntdiary · 2023-11-16T12:31:32Z

Hi, I need to spend more time on another modal refocusing issue, so I plan to un-assign myself. If @chiragsalian is available, please feel free to push forward. :)

Well, I can't un-assign myself in a PR...😅

situchan · 2023-11-16T13:28:58Z

I can take this over if @ntdiary agrees

ntdiary · 2023-11-17T08:28:46Z

I can take this over if @ntdiary agrees

@situchan, please feel free to push forward if needed. 🚀

situchan · 2023-11-17T12:33:06Z

@srikarparsi please pull main. It maybe fix author checklist failing.

srikarparsi · 2023-11-21T07:16:44Z

Hi, I didn't add the other screenshots yet which is why author checklist is failing. Please review it if you have a chance in the meantime though and I'll add screenshots tomorrow :)

situchan · 2023-11-21T07:28:54Z

Missing screenshots doesn't affect checklist. If you pull main, I think it will be fixed.

situchan · 2023-11-21T07:29:34Z

And https://github.com/Expensify/Auth/pull/9222 is deployed to staging/production?

chiragsalian · 2023-11-21T18:28:16Z

And https://github.com/Expensify/Auth/pull/9222 is deployed to staging/production?

nope its not merged yet.

srikarparsi · 2023-11-28T02:04:56Z

Hey @situchan, Auth PR is on production now so this is ready for review :)

situchan · 2023-11-30T14:40:49Z

Please complete author checklist when you get a chance

merge main

srikarparsi · 2023-12-11T04:31:24Z

Finished the checklist and merged main, it's ready for review whenever you get a chance @situchan

situchan · 2023-12-21T19:44:03Z

Code LGTM! Testing

situchan · 2023-12-21T19:54:42Z

@srikarparsi Leave case works well. I think we should implement same for Join case.
So optimistically subscribe when join. I tested and confirmed this was implemented already in backend.

srikarparsi · 2023-12-21T20:04:18Z

Thanks for the review! For joining a room, I believe we already optimistically subscribe when we join.

Join room button calls updateNotificationPreference here

Update notification preference sends optimistic data for childReportNotificationPreference here

Was this what you were referring to or something else?

situchan · 2023-12-21T20:10:05Z

Thanks for the review! For joining a room, I believe we already optimistically subscribe when we join.

Join room button calls updateNotificationPreference here

Update notification preference sends optimistic data for childReportNotificationPreference here

Was this what you were referring to or something else?

I reported based on testing

Screen.Recording.2023-12-22.at.2.08.30.AM.mov

situchan · 2023-12-21T20:17:13Z

I think I found the root cause. parentReportID is 5th param of updateNotificationPreference but it's not being passed.
Should this be fixed separately? Or here in this PR? I am fine either way. Just to confirm

merge main

srikarparsi · 2024-01-01T00:09:23Z

Nice, thanks @situchan. Yeah, I just added in the fix for it here since it's pretty straightforward.

merge main for test

situchan · 2024-01-04T06:32:09Z

Please resolve conflict came from #33791 you reviewed

situchan · 2024-01-04T07:21:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

situchan

melvin-bot · 2024-01-04T07:22:19Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

deetergp · 2024-01-05T19:58:11Z

@srikarparsi You've got a failing Reassure Performance Tests failure. Not sure how to go about addressing that…

situchan · 2024-01-05T19:59:36Z

@srikarparsi You've got a failing Reassure Performance Tests failure. Not sure how to go about addressing that…

It's unrelated.
We disabled that test temporarily in #34042 so after pulling main, it will be gone

…pensify/App into srikar-updateSubscribeOnLeave merge main into branch

OSBotify · 2024-01-06T01:21:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-09T05:35:33Z

🚀 Deployed to staging by https://github.com/deetergp in version: 1.4.23-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-10T06:02:48Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.23-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

update subsribe on leave

229a433

srikarparsi self-assigned this Nov 3, 2023

srikarparsi added 3 commits November 9, 2023 04:16

Merge branch 'main' into srikar-updateSubscribeOnLeave

52f848b

merge main

fix variable names

1e060e2

Merge branch 'main' into srikar-updateSubscribeOnLeave

1ea5e25

merge main

srikarparsi marked this pull request as ready for review November 16, 2023 09:29

srikarparsi requested a review from a team as a code owner November 16, 2023 09:29

melvin-bot bot requested review from ntdiary and removed request for a team November 16, 2023 09:29

srikarparsi requested review from chiragsalian and a team and removed request for ntdiary November 16, 2023 09:29

melvin-bot bot requested review from ntdiary and removed request for a team November 16, 2023 09:29

srikarparsi requested review from situchan and removed request for ntdiary November 27, 2023 21:34

Merge branch 'main' into srikar-updateSubscribeOnLeave

a7885d9

merge main

situchan mentioned this pull request Dec 12, 2023

[HOLD for payment 2024-01-17] Unsubscribe icon shows up after leaving your own thread #30546

Closed

6 tasks

merge conflicts

efa3620

srikarparsi added 4 commits December 21, 2023 15:43

optimistic data for join room

99ff60a

parent report action id

beb6601

Merge branch 'main' into srikar-updateSubscribeOnLeave

d2d3f69

merge main

prettier

e76dd01

Merge branch 'main' into srikar-updateSubscribeOnLeave

48b9b94

merge main for test

Merge branch 'main' into srikar-updateSubscribeOnLeave

d9ddd7f

situchan approved these changes Jan 4, 2024

View reviewed changes

melvin-bot bot requested a review from deetergp January 4, 2024 07:22

srikarparsi added 2 commits January 5, 2024 15:46

merge main

596e56b

Merge branch 'srikar-updateSubscribeOnLeave' of https://github.com/Ex…

a67c871

…pensify/App into srikar-updateSubscribeOnLeave merge main into branch

deetergp approved these changes Jan 6, 2024

View reviewed changes

deetergp merged commit 0c351a4 into main Jan 6, 2024
13 checks passed

deetergp deleted the srikar-updateSubscribeOnLeave branch January 6, 2024 01:16

github-actions bot mentioned this pull request Jan 9, 2024

Deploy Checklist: New Expensify 2024-01-09 #34121

Closed

87 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update subscribe on leave #30812

Update subscribe on leave #30812

srikarparsi commented Nov 3, 2023 •

edited

Loading

melvin-bot bot commented Nov 16, 2023

melvin-bot bot commented Nov 16, 2023

ntdiary commented Nov 16, 2023 •

edited

Loading

situchan commented Nov 16, 2023

ntdiary commented Nov 17, 2023

situchan commented Nov 17, 2023

srikarparsi commented Nov 21, 2023

situchan commented Nov 21, 2023

situchan commented Nov 21, 2023

chiragsalian commented Nov 21, 2023

srikarparsi commented Nov 28, 2023

situchan commented Nov 30, 2023

srikarparsi commented Dec 11, 2023

situchan commented Dec 21, 2023

situchan commented Dec 21, 2023

srikarparsi commented Dec 21, 2023

situchan commented Dec 21, 2023

situchan commented Dec 21, 2023

srikarparsi commented Jan 1, 2024

situchan commented Jan 4, 2024

situchan commented Jan 4, 2024

situchan left a comment

melvin-bot bot commented Jan 4, 2024

deetergp commented Jan 5, 2024

situchan commented Jan 5, 2024

OSBotify commented Jan 6, 2024

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

Update subscribe on leave #30812

Update subscribe on leave #30812

Conversation

srikarparsi commented Nov 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 16, 2023

melvin-bot bot commented Nov 16, 2023

ntdiary commented Nov 16, 2023 • edited Loading

situchan commented Nov 16, 2023

ntdiary commented Nov 17, 2023

situchan commented Nov 17, 2023

srikarparsi commented Nov 21, 2023

situchan commented Nov 21, 2023

situchan commented Nov 21, 2023

chiragsalian commented Nov 21, 2023

srikarparsi commented Nov 28, 2023

situchan commented Nov 30, 2023

srikarparsi commented Dec 11, 2023

situchan commented Dec 21, 2023

situchan commented Dec 21, 2023

srikarparsi commented Dec 21, 2023

situchan commented Dec 21, 2023

situchan commented Dec 21, 2023

srikarparsi commented Jan 1, 2024

situchan commented Jan 4, 2024

situchan commented Jan 4, 2024

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jan 4, 2024

deetergp commented Jan 5, 2024

situchan commented Jan 5, 2024

OSBotify commented Jan 6, 2024

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

srikarparsi commented Nov 3, 2023 •

edited

Loading

ntdiary commented Nov 16, 2023 •

edited

Loading