fix: console error old-dot to new-dot new workspace transition #30115

jeet-dhandha · 2023-10-21T04:37:00Z

Details

Creating workspace from OldDot to NewDot generates console errors, as we are trying to store React elements into Onyx. Another console error is for an initial param openOnAdminRoom where we are passing prop as 'true' instead of boolean true. So we are fixing this two errors in this PR.

Fixed Issues

$ #28262
PROPOSAL: #28262 (comment)

Tests

This PR can be tested on Web only.
Open www.expensify.com then login with user A.
Open staging.new.expensify.com then login with user B.
Now goto Settings Tab > Workspaces.
Now in Workspaces goto Group tab and press New Workspace on top right.
Select Free workspace type.
Now as new tab opens up copy the exisiting URL and change its domain to staging.new.expensify.com / http//localhost:8080.
Now open inspect options and go to Console's tab verify no console are visible.

Verify that no errors appear in the JS console

Offline tests

There won't be no Offline Steps as website won't open in Offline

QA Steps

This PR can be tested on Web only.
Open www.expensify.com then login with user A.
Open staging.new.expensify.com then login with user B.
Now goto Settings Tab > Workspaces.
Now in Workspaces goto Group tab and press New Workspace on top right.
Select Free workspace type.
Now as new tab opens up copy the exisiting URL and change its domain to staging.new.expensify.com / http//localhost:8080.
Now open inspect options and go to Console's tab verify no console are visible.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

12fee809-6d05-410c-819d-7bc0a579b5d6.mp4

MacOS: Desktop

melvin-bot · 2023-10-21T04:39:53Z

@ArekChr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jeet-dhandha · 2023-10-21T04:40:59Z

@ArekChr I won't be able to add video's for other platforms as this can only be tested on Web Platform.

ArekChr · 2023-10-23T12:44:51Z

@mollfpr I believe there may have been a mix-up in assigning me as a reviewer for this PR. Would you prefer to take over the review, or would you like me to proceed with it?

mollfpr

@ArekChr Sorry for the ping. I'm not on the team, so Melvin won't request a review from me, and I'll take this PR review 🙏

mollfpr · 2023-10-23T14:48:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

30115.Web.mp4

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

mollfpr

This is make sense to me we only need to test it on web.

LGTM and tests well 👍

All yours @Li357

jeet-dhandha · 2023-10-24T08:10:38Z

@Li357 @mollfpr when are we planning to merge this. As i would want the bonus if its under our reach.

jeet-dhandha · 2023-10-25T04:08:58Z

Any updates here ?

mollfpr · 2023-10-25T04:47:22Z

Friendly bump @Li357 for final review

jeet-dhandha · 2023-10-26T03:32:46Z

@Li357 are we holding onto this PR for something?

0xmiros

I didn't review this. Approving just to assign engineer

Li357 · 2023-10-30T16:07:36Z

Merged, sorry for the delay since I'm working part-time. You'll still get the bonus if that applies, we'll exclude any extra days it took me to get to this.

OSBotify · 2023-10-30T18:00:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-31T22:00:22Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-01T08:52:21Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:15:42Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:40:32Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-06T22:10:35Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: console error old-dot to new-dot new workspace transition

0daa9f1

jeet-dhandha marked this pull request as ready for review October 21, 2023 04:39

jeet-dhandha requested a review from a team as a code owner October 21, 2023 04:39

melvin-bot bot requested review from ArekChr and removed request for a team October 21, 2023 04:39

mollfpr reviewed Oct 23, 2023

View reviewed changes

mollfpr approved these changes Oct 23, 2023

View reviewed changes

Merge branch 'main' into fix-28262

7c89e90

Merge branch 'main' into fix-28262

7132907

0xmiros approved these changes Oct 27, 2023

View reviewed changes

melvin-bot bot requested a review from Li357 October 27, 2023 19:20

Li357 approved these changes Oct 30, 2023

View reviewed changes

Li357 merged commit 0df9c69 into Expensify:main Oct 30, 2023

OSBotify mentioned this pull request Oct 31, 2023

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed

97 tasks

melvin-bot bot mentioned this pull request Nov 2, 2023

[HOLD for payment 2023-11-09] [$500] Web - New Dot Showing Console Error's when Creating New Policy from OldDot #28262

Closed

6 tasks

OSBotify mentioned this pull request Nov 2, 2023

Deploy Checklist: New Expensify 2023-11-02 #30752

Closed

jeet-dhandha deleted the fix-28262 branch November 2, 2023 18:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: console error old-dot to new-dot new workspace transition #30115

fix: console error old-dot to new-dot new workspace transition #30115

jeet-dhandha commented Oct 21, 2023 •

edited

Loading

melvin-bot bot commented Oct 21, 2023

jeet-dhandha commented Oct 21, 2023

ArekChr commented Oct 23, 2023

mollfpr left a comment

mollfpr commented Oct 23, 2023 •

edited

Loading

mollfpr left a comment

jeet-dhandha commented Oct 24, 2023

jeet-dhandha commented Oct 25, 2023

mollfpr commented Oct 25, 2023

jeet-dhandha commented Oct 26, 2023

0xmiros left a comment

Li357 commented Oct 30, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

OSBotify commented Nov 1, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

fix: console error old-dot to new-dot new workspace transition #30115

fix: console error old-dot to new-dot new workspace transition #30115

Conversation

jeet-dhandha commented Oct 21, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 21, 2023

jeet-dhandha commented Oct 21, 2023

ArekChr commented Oct 23, 2023

mollfpr left a comment

Choose a reason for hiding this comment

mollfpr commented Oct 23, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

jeet-dhandha commented Oct 24, 2023

jeet-dhandha commented Oct 25, 2023

mollfpr commented Oct 25, 2023

jeet-dhandha commented Oct 26, 2023

0xmiros left a comment

Choose a reason for hiding this comment

Li357 commented Oct 30, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

OSBotify commented Nov 1, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

jeet-dhandha commented Oct 21, 2023 •

edited

Loading

mollfpr commented Oct 23, 2023 •

edited

Loading