Fix crash app when opening split bill detail page by deep link #23977

dukenv0307 · 2023-08-01T04:31:40Z

Details

Fix crash app when opening split bill detail page by deep link

Fixed Issues

$ #23568
PROPOSAL: #23568 (comment)

Tests

Login with any account
Click on FAB > Split bill
Enter any amount and choose some users to create split bill
After the split bill is created, click on this to see split bill detail
Copy the URL
Sign out and sign in again with the URL above
Verify that the app doesn't crash and split bill detail appears after loading is complete

Verify that no errors appear in the JS console

Offline tests

Need online to open the app by deep link

QA Steps

Click on the text input to bring it into focus
Upload an image via copy paste
Verify a modal appears displaying a preview of that image
--->
Login with any account
Click on FAB > Split bill
Enter any amount and choose some users to create split bill
After the split bill is created, click on this to see split bill detail
Copy the URL
Sign out and sign in again with the URL above
Verify that the app doesn't crash and split bill detail appears after loading is complete

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Note: For native, if we open by deep link before login app still go to LHN after login successfully. So in the video for IOS and Android, we open by deep link after login.

Web

Screen-Recording-2023-08-02-at-10.09.20.mp4

Mobile Web - Chrome

Record_2023-08-01-14-11-45.mp4

Mobile Web - Safari

Screen-Recording-2023-08-01-at-15.22.17.mp4

Desktop

Screen.Recording.2023-08-01.at.12.30.35.mp4

iOS

Screen-Recording-2023-08-01-at-14.22.23.mp4

Android

23568.mp4

melvin-bot · 2023-08-01T05:37:46Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-08-02T03:13:26Z

@mananjadhav Friendly bump.

mananjadhav · 2023-08-02T04:21:46Z

Reviewing this currently. Will finish this in a few hours.

mananjadhav · 2023-08-02T05:33:34Z

src/pages/home/report/withReportAndReportActionOrNotFound.js

+        forwardedRef: () => {},
+        reportActions: {},
+        report: {
+            isLoadingReportActions: true,


Why do we need isLoadingReportingActions: true in default props? Why can't we have empty?

Yes I think we can remove this. I add this to verify that this will loading until the API is complete.

mananjadhav · 2023-08-02T05:35:24Z

src/pages/home/report/withReportAndReportActionOrNotFound.js

+
+    // eslint-disable-next-line rulesdir/no-negated-variables
+    function WithReportAndReportActionOrNotFound(props) {
+        // For small screen, we don't call openReport API when we go to a sub report page by deeplinnk


I'll have to verify this, can you confirm if this is documented somewhere?

If we open a sub report link the app doesn't call openReport API in openReportByDeepLink function. And in small screen, we go to sidebar after login in. That is why it doesn't call openReport API in small screen after login.

I tested this in small screen without this and it display not found page.

Do you think we should alway call openReport one time here if props.report is empty.

mananjadhav · 2023-08-02T05:35:33Z

src/pages/home/report/withReportAndReportActionOrNotFound.js

+
+    // eslint-disable-next-line rulesdir/no-negated-variables
+    function WithReportAndReportActionOrNotFound(props) {
+        // For small screen, we don't call openReport API when we go to a sub report page by deeplinnk


Suggested change

// For small screen, we don't call openReport API when we go to a sub report page by deeplinnk

// For small screen, we don't call openReport API when we go to a sub report page by deeplink

mananjadhav · 2023-08-02T05:38:18Z

src/pages/home/report/withReportAndReportActionOrNotFound.js

+                key: ONYXKEYS.COLLECTION.POLICY,
+            },
+            reportActions: {
+                key: ({route}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${route.params.reportID}`,


Original code explicitly added toString(). Would this break something if we don't put toString?

I think that fine because we wrap it in `` that is a string.

mananjadhav · 2023-08-02T05:42:27Z

src/pages/home/report/withReportAndReportActionOrNotFound.js

+
+        let reportAction = props.reportActions[`${props.route.params.reportActionID.toString()}`];
+        // Handle threads if needed
+        if (reportAction === undefined || reportAction.reportActionID === undefined) {


I think this section can be moved to this own method?

It should be checked here to verify the reportAction is exist or not.

I am fine, I am saying just move this block to it's own method?

Do you mean we should create a method for this?

This whole block.

let reportAction = props.reportActions[`${props.route.params.reportActionID.toString()}`]; // Handle threads if needed if (reportAction === undefined || reportAction.reportActionID === undefined) { reportAction = ReportActionsUtils.getParentReportAction(props.report); }

mananjadhav · 2023-08-02T05:45:18Z

src/pages/home/report/withReportAndReportActionOrNotFound.js

+            }
+        }, [props.isSmallScreenWidth, props.route.params.reportID]);
+
+        const isLoadingReport = props.isLoadingReportData && (_.isEmpty(props.report) || !props.report.reportID);


I understand these checks are complex, but we generally try to early return. Is it possible to structure the code:

// Perform all the loading checks const isLoadingReport = ...; const isLoadingReportAction = ....; if ((isLoadingReport || isLoadingReportAction) && !shouldHideReport) { return <FullscreenLoadingIndicator />; } // Perform the access/not found checks const shouldHideReport if (shouldHideReport || _.isEmpty(reportAction)) { return <NotFoundPage />; }

mananjadhav · 2023-08-02T05:46:03Z

src/pages/home/report/withReportAndReportActionOrNotFound.js

+        if ((isLoadingReport || isLoadingReportAction) && !shouldHideReport) {
+            return <FullscreenLoadingIndicator />;
+        }
+        if (shouldHideReport || _.isEmpty(reportAction)) {


Please check my comment above and then I feel shouldHideReport won't be needed, the conditions can be put here inline.

I will check and re-test again.

Some reports contain data but we can not access this report by ReportUtils.canAccessReport fucntion, so this check is necessary to display not found page.

mananjadhav · 2023-08-02T05:47:41Z

@dukenv0307 I've left some comments, I'll be available to review in another 2-3 hours.

dukenv0307 · 2023-08-02T07:38:38Z

@mananjadhav Updated for all recommendations above.

mananjadhav · 2023-08-02T11:46:54Z

src/pages/home/report/withReportAndReportActionOrNotFound.js

+            }
+            Report.openReport(props.route.params.reportID);
+            // eslint-disable-next-line react-hooks/exhaustive-deps
+        }, []);


Why would we not want to depend on the props.isSmallScreenWdith and props.report ?

mananjadhav · 2023-08-02T11:47:32Z

@dukenv0307 1-2 comments and the rest of it looks good.

mananjadhav · 2023-08-02T11:49:02Z

src/pages/home/report/withReportAndReportActionOrNotFound.js

+        // Perform all the loading checks
+        const isLoadingReport = props.isLoadingReportData && (_.isEmpty(props.report) || !props.report.reportID);
+        const isLoadingReportAction = _.isEmpty(props.reportActions) || (props.report.isLoadingReportActions && _.isEmpty(getReportAction()));
+        const shouldHideReport = !isLoadingReport && (_.isEmpty(props.report) || !props.report.reportID || !ReportUtils.canAccessReport(props.report, props.policies, props.betas));


Possible to move this check after the return <FullScreenLoadingIndicator>?

testing again if it's possible

mananjadhav · 2023-08-02T11:49:34Z

src/pages/home/report/withReportAndReportActionOrNotFound.js

+        const isLoadingReportAction = _.isEmpty(props.reportActions) || (props.report.isLoadingReportActions && _.isEmpty(getReportAction()));
+        const shouldHideReport = !isLoadingReport && (_.isEmpty(props.report) || !props.report.reportID || !ReportUtils.canAccessReport(props.report, props.policies, props.betas));
+
+        if ((isLoadingReport || isLoadingReportAction) && !shouldHideReport) {


Inline with the above comment, anyway to remove !shouldHideReport from here so that the flag is only initialized after this block?

This check is necessary here. if reportID is not found props.reportAction is true and isLoadingReportAction is true, so we need shouldHideReport here to return false if the report doesn't exist.

Okay thanks.

mananjadhav · 2023-08-02T12:30:12Z

src/pages/home/report/withReportAndReportActionOrNotFound.js

+            }
+            Report.openReport(props.route.params.reportID);
+            // eslint-disable-next-line react-hooks/exhaustive-deps
+        }, []);


We're only left with this now @dukenv0307? Do we need to disable the exhaustive-deps check? Why not add the props.isSmallScreenWidth, props.report, props.route.params.reportID to the dependencies?

I think we only need to call this API one time here.

Are we sure?

What happens when we're on Desktop/Web and resize the browser? and then perform the steps?

Assume that we've got more than one Split bill requests URL shared on chat, and we click on both one after the other?

Cool will add dependence again.

Hey,
Sorry I should've been clear. I am not saying always need to add the dependencies. I wanted to know if it is required? If not, then we add a comment why certain properties are not required.

For example,

I feel isSmallScreenWidth is required

I am not confident about props.report?

and I am pretty sure we don't need route.params.reportID as that would mean opening a new URL, which should probably reload the whole component, thereby calling useEffect

Please correct me if I my understanding is wrong? May be you could test at your end?

isSmallScreenWidth and route.param.reportID will be fine because inn native if we already open a split bill and we open other by deeplink maybe this component will not unmount.

@mananjadhav updated, help to check again.

thanks @dukenv0307. I'll test this in an hour.

mananjadhav

Thanks for addressing the changes. I am now testing this.

mananjadhav · 2023-08-02T16:03:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-split-bill-crash.mov

Mobile Web - Chrome

mweb-chrome-split-bill-crash.mov

Mobile Web - Safari

mweb-safari-split-bill-crash.mov

Desktop

desktop-split-bill-crash.mov

iOS

ios-split-bill-crash.mov

Android

android-split-bill-crash.mov

mananjadhav · 2023-08-02T17:00:29Z

@dukenv0307 This isn't working for me. I thought it was an issue with my account, so I created a new account. It just keeps loading.

const isLoadingReportAction = _.isEmpty(props.reportActions) || (props.report.isLoadingReportActions && _.isEmpty(getReportAction()));

This is always true for me.

web-report-actions-not-loading.mov

dukenv0307 · 2023-08-02T17:13:33Z

@mananjadhav You can see the report screen the report doesn't loading completely

dukenv0307 · 2023-08-02T17:18:52Z

@mananjadhav Can you run npm install and test again?

dukenv0307 · 2023-08-02T17:28:20Z

@mananjadhav Can you check again, I tested and it works as well. In the video above, because the ReportScreen loading infinitely, SplitBillDetailPage also loading.

Screencast.from.03-08-2023.00.26.09.webm

mananjadhav · 2023-08-02T18:43:12Z

@dukenv0307 There was an issue with the Expensify servers. I thought it was because of the PR, because it loaded on main. Anyway this worked fine on Web, now testing on other platforms.

mananjadhav · 2023-08-02T19:23:11Z

Thanks for the patience here @dukenv0307. This tests well. I can we don't link the URLs on native, which exists on the main too.

@Li357 All yours.

Li357

LGTM! Thanks y'all for getting this out!

OSBotify · 2023-08-02T19:35:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-03T17:41:40Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:30:00Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:57:13Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T08:46:21Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix crash app when opening split bill page by loading

b86968f

dukenv0307 marked this pull request as ready for review August 1, 2023 05:37

dukenv0307 requested a review from a team as a code owner August 1, 2023 05:37

melvin-bot bot removed the request for review from a team August 1, 2023 05:37

melvin-bot bot requested a review from mananjadhav August 1, 2023 05:37

dukenv0307 mentioned this pull request Aug 1, 2023

[Awaiting C+ payment] [$1000] App crashes on login after opening split bill details page #23568

Closed

6 tasks

update HOC to work for small screen

a809aa3

dukenv0307 mentioned this pull request Aug 2, 2023

Fix infinite loading in Flag page in offline #23775

Merged

58 tasks

mananjadhav reviewed Aug 2, 2023

View reviewed changes

refactor HOC

60a7ea3

fedirjh mentioned this pull request Aug 2, 2023

[HOLD for payment 2023-08-17] [$1000] Chat - Infinite loading after selecting flag option offline #23125

Closed

6 tasks

mananjadhav reviewed Aug 2, 2023

View reviewed changes

call API if reportAction is empty

1965a7a

mananjadhav reviewed Aug 2, 2023

View reviewed changes

dukenv0307 added 2 commits August 2, 2023 19:40

add dependencies for useEffect

ead3a3d

optimize dependencies

70e497f

mananjadhav approved these changes Aug 2, 2023

View reviewed changes

melvin-bot bot requested a review from Li357 August 2, 2023 16:03

Li357 approved these changes Aug 2, 2023

View reviewed changes

Li357 merged commit cf4e837 into Expensify:main Aug 2, 2023

OSBotify mentioned this pull request Aug 3, 2023

Deploy Checklist: New Expensify 2023-08-03 #24121

Closed

86 tasks

OSBotify mentioned this pull request Aug 7, 2023

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed

98 tasks

dukenv0307 mentioned this pull request Oct 18, 2023

Open the correct report when access sub report page by deep link #29739

Merged

59 tasks

	// For small screen, we don't call openReport API when we go to a sub report page by deeplinnk
	// For small screen, we don't call openReport API when we go to a sub report page by deeplink

Fix crash app when opening split bill detail page by deep link #23977

Fix crash app when opening split bill detail page by deep link #23977

Conversation

dukenv0307 commented Aug 1, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 1, 2023

dukenv0307 commented Aug 2, 2023

mananjadhav commented Aug 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mananjadhav Aug 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mananjadhav commented Aug 2, 2023

dukenv0307 commented Aug 2, 2023

Choose a reason for hiding this comment

mananjadhav commented Aug 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mananjadhav left a comment

Choose a reason for hiding this comment

mananjadhav commented Aug 2, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented Aug 2, 2023

dukenv0307 commented Aug 2, 2023

dukenv0307 commented Aug 2, 2023

dukenv0307 commented Aug 2, 2023

mananjadhav commented Aug 2, 2023

mananjadhav commented Aug 2, 2023

Li357 left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 2, 2023

OSBotify commented Aug 3, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 9, 2023

dukenv0307 commented Aug 1, 2023 •

edited

Loading

mananjadhav Aug 2, 2023 •

edited

Loading

mananjadhav commented Aug 2, 2023 •

edited

Loading

mananjadhav commented Aug 2, 2023 •

edited

Loading