Fix infinite loading in Flag page in offline #23775

dukenv0307 · 2023-07-28T03:36:17Z

Details

In offline mode, sometimes the flag page shows loading infinitely. We need to change the condition show loading to fix it

Fixed Issues

$ #23125
PROPOSAL: #23125 (comment)

Tests

Login with user A
On another device, login with user B
From user B, send a message to user A
From user A, go offline
Go to any other report
Go back to the report
Tap the message and select "Flag as offensive"
Verify that the flag page appears instead of loading infinitely

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Login with user A
On another device, login with user B
From user B, send a message to user A
From user A, go offline
Go to any other report
Go back to the report
Tap the message and select "Flag as offensive"
Verify that the flag page appears instead of loading infinitely

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screencast.from.28-07-2023.10.41.29.webm

Mobile Web - Chrome

Record_2023-07-28-10-44-04.mp4

Mobile Web - Safari

safari_cp.mp4

Desktop

desktop.2.mp4

iOS

ios.mov

Android

android.mp4

melvin-bot · 2023-08-01T02:10:09Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-08-01T04:59:12Z

@fedirjh In this issue #23568 (comment) we decided to create new HOC for the page need both report and reportAction data. So we can hold this PR until the PR in #23568 is complete to re-use the HOC here.

fedirjh · 2023-08-01T18:50:24Z

src/pages/FlagCommentPage.js

+    const isLoadingInitialReport = props.isLoadingReportData && _.isEmpty(props.report);
+    const isLoadingInitialReportActions = _.isEmpty(props.reportActions) || (props.report.isLoadingReportActions && _.isEmpty(getActionToFlag()));
+    const isExistReport = isLoadingInitialReport || (!_.isEmpty(props.report) && !!props.report.reportID);
+
+    const shouldShowLoading = (isLoadingInitialReport || isLoadingInitialReportActions) && isExistReport;


@dukenv0307 Can you explain the changes? why we didn’t just update the line to

const shouldShowLoading = (props.isLoadingReportData && isEmpty(props.report) || (isEmpty(props.reportActions) && props.report.isLoadingReportActions)

@fedirjh

when openApp API is complete props.report.isLoadingReportAction for now is undefined because openReport isn't called.

_.isEmpty(props.reportActions) to wait oenReport API is called. But sometimes, props.reportActions is not empty by another api that is readOldestAction and props.reportActions doesn't contain reportAction with reportActionID param. That is the reason we should check reportAction like isLoadingInitialReportActions

if report doesn't exist we don't need to check any thing else that is isExistReport

Because split bill page also has both reportID and reportActionID in param, so we decided to create a new HOC to use for two pages and we can use this in the further. We can see the implement for HOC in this PR Fix crash app when opening split bill detail page by deep link #23977

Since we will implement HOC in the other PR, let's hold this PR, then use the same HOC in this component.

Do we need to change the title of this PR?

I think so, I will leave a note inside the linked issue.

dukenv0307 · 2023-08-03T03:22:55Z

@fedirjh #23977 is merged. Can we continue with this PR or wait #23977 is deployed to production?

fedirjh · 2023-08-04T10:18:02Z

cc @dukenv0307, Let's continue with this PR, we shouldn’t merge it until #23977 is deployed to production.

dukenv0307 · 2023-08-04T10:39:01Z

@fedirjh Updated the PR with the new HOC.

dukenv0307 · 2023-08-07T03:47:05Z

@fedirjh Bump

fedirjh · 2023-08-07T16:25:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

CleanShot.2023-08-07.at.13.17.31.mp4

Mobile Web - Chrome

CleanShot.2023-08-07.at.16.07.01.mp4

Mobile Web - Safari

CleanShot.2023-08-07.at.15.38.50.mp4

Desktop

CleanShot.2023-08-07.at.15.28.35.mp4

iOS

CleanShot.2023-08-07.at.15.36.07.mp4

Android

CleanShot.2023-08-07.at.16.23.45.mp4

fedirjh

Looks good to me.

🎀 👀 🎀 C+ reviewed

srikarparsi

lgtm as well!

OSBotify · 2023-08-08T05:47:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-09T09:11:44Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:50:27Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-10T20:08:53Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 added 3 commits July 28, 2023 10:29

Fix infinite loading in offline

7fe67b0

clear condition

24f5b11

update the condition

5c98369

dukenv0307 marked this pull request as ready for review August 1, 2023 02:10

dukenv0307 requested a review from a team as a code owner August 1, 2023 02:10

melvin-bot bot requested review from fedirjh and removed request for a team August 1, 2023 02:10

fedirjh reviewed Aug 1, 2023

View reviewed changes

dukenv0307 changed the title ~~Fix infinite loading in Flag page in offline~~ [Hold #23977]Fix infinite loading in Flag page in offline Aug 2, 2023

dukenv0307 changed the title ~~[Hold #23977]Fix infinite loading in Flag page in offline~~ Fix infinite loading in Flag page in offline Aug 4, 2023

dukenv0307 added 3 commits August 4, 2023 17:24

Merge branch 'main' into fix/23125

6688cb8

implement flag page with HOC

f6e1f73

refactor flag page

cbca70c

fedirjh approved these changes Aug 7, 2023

View reviewed changes

melvin-bot bot requested a review from srikarparsi August 7, 2023 16:33

srikarparsi approved these changes Aug 8, 2023

View reviewed changes

srikarparsi merged commit 012d604 into Expensify:main Aug 8, 2023
2 checks passed

OSBotify mentioned this pull request Aug 9, 2023

Deploy Checklist: New Expensify 2023-08-09 #24307

Closed

87 tasks

melvin-bot bot mentioned this pull request Aug 10, 2023

[HOLD for payment 2023-08-17] [$1000] Chat - Infinite loading after selecting flag option offline #23125

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix infinite loading in Flag page in offline #23775

Fix infinite loading in Flag page in offline #23775

dukenv0307 commented Jul 28, 2023 •

edited

Loading

melvin-bot bot commented Aug 1, 2023

dukenv0307 commented Aug 1, 2023 •

edited

Loading

fedirjh Aug 1, 2023

dukenv0307 Aug 2, 2023

fedirjh Aug 2, 2023

dukenv0307 Aug 2, 2023 •

edited

Loading

fedirjh Aug 2, 2023 •

edited

Loading

dukenv0307 commented Aug 3, 2023 •

edited

Loading

fedirjh commented Aug 4, 2023

dukenv0307 commented Aug 4, 2023

dukenv0307 commented Aug 7, 2023

fedirjh commented Aug 7, 2023

fedirjh left a comment

srikarparsi left a comment

OSBotify commented Aug 8, 2023

OSBotify commented Aug 9, 2023

OSBotify commented Aug 9, 2023

OSBotify commented Aug 10, 2023

Fix infinite loading in Flag page in offline #23775

Fix infinite loading in Flag page in offline #23775

Conversation

dukenv0307 commented Jul 28, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 1, 2023

dukenv0307 commented Aug 1, 2023 • edited Loading

fedirjh Aug 1, 2023

Choose a reason for hiding this comment

dukenv0307 Aug 2, 2023

Choose a reason for hiding this comment

fedirjh Aug 2, 2023

Choose a reason for hiding this comment

dukenv0307 Aug 2, 2023 • edited Loading

Choose a reason for hiding this comment

fedirjh Aug 2, 2023 • edited Loading

Choose a reason for hiding this comment

dukenv0307 commented Aug 3, 2023 • edited Loading

fedirjh commented Aug 4, 2023

dukenv0307 commented Aug 4, 2023

dukenv0307 commented Aug 7, 2023

fedirjh commented Aug 7, 2023

Reviewer Checklist

Screenshots/Videos

fedirjh left a comment

Choose a reason for hiding this comment

srikarparsi left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 8, 2023

OSBotify commented Aug 9, 2023

OSBotify commented Aug 9, 2023

OSBotify commented Aug 10, 2023

dukenv0307 commented Jul 28, 2023 •

edited

Loading

dukenv0307 commented Aug 1, 2023 •

edited

Loading

dukenv0307 Aug 2, 2023 •

edited

Loading

fedirjh Aug 2, 2023 •

edited

Loading

dukenv0307 commented Aug 3, 2023 •

edited

Loading