From 502f8dbf34af453cc1eb06033c1be1d49df970d4 Mon Sep 17 00:00:00 2001 From: Sibtain Ali Date: Fri, 2 Jun 2023 00:49:44 +0500 Subject: [PATCH 1/3] fix: add storybook check to ci tests --- .github/workflows/test.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a2b92ea771b5..7cc2547f34c3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -35,6 +35,16 @@ jobs: - name: Jest tests run: npx jest --silent --shard=${{ fromJSON(matrix.chunk) }}/${{ strategy.job-total }} --max-workers ${{ steps.cpu-cores.outputs.count }} + + storybookTests: + if: ${{ github.actor != 'OSBotify' || github.event_name == 'workflow_call' }} + runs-on: ubuntu-latest + name: Storybook tests + steps: + - uses: actions/checkout@885641592076c27bfb56c028cd5612cdad63e16d + - uses: Expensify/App/.github/actions/composite/setupNode@main + - name: Storybook run + run: npm run storybook -- --smoke-test --ci shellTests: if: ${{ github.actor != 'OSBotify' || github.event_name == 'workflow_call' }} From 503ff87fe42e0fdea9c2749ab89954571e195c78 Mon Sep 17 00:00:00 2001 From: Sibtain Ali Date: Fri, 2 Jun 2023 01:38:38 +0500 Subject: [PATCH 2/3] test --- config/webpack/webpack.common.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/webpack/webpack.common.js b/config/webpack/webpack.common.js index 9bae001c2b53..f263d8700030 100644 --- a/config/webpack/webpack.common.js +++ b/config/webpack/webpack.common.js @@ -72,7 +72,7 @@ const webpackConfig = ({envFile = '.env', platform = 'web'}) => ({ new HtmlWebpackPlugin({ template: 'web/index.html', filename: 'index.html', - splashLogo: fs.readFileSync(path.resolve(__dirname, `../../assets/images/new-expensify${mapEnvToLogoSuffix(envFile)}.svg`), 'utf-8'), + splashLogo: fs.readFileSync(path.resolve(__dirname, `../../assets/images/new-expensify.svg`), 'utf-8'), usePolyfillIO: platform === 'web', isStaging: envFile === '.env.staging', }), From 298a5245c844db58c91d0d2c17a16cd206944a08 Mon Sep 17 00:00:00 2001 From: Sibtain Ali Date: Fri, 2 Jun 2023 01:44:37 +0500 Subject: [PATCH 3/3] revert webpack changes --- config/webpack/webpack.common.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/webpack/webpack.common.js b/config/webpack/webpack.common.js index f263d8700030..9bae001c2b53 100644 --- a/config/webpack/webpack.common.js +++ b/config/webpack/webpack.common.js @@ -72,7 +72,7 @@ const webpackConfig = ({envFile = '.env', platform = 'web'}) => ({ new HtmlWebpackPlugin({ template: 'web/index.html', filename: 'index.html', - splashLogo: fs.readFileSync(path.resolve(__dirname, `../../assets/images/new-expensify.svg`), 'utf-8'), + splashLogo: fs.readFileSync(path.resolve(__dirname, `../../assets/images/new-expensify${mapEnvToLogoSuffix(envFile)}.svg`), 'utf-8'), usePolyfillIO: platform === 'web', isStaging: envFile === '.env.staging', }),