Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fastlane to 2.178 #1953

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Update fastlane to 2.178 #1953

merged 1 commit into from
Mar 19, 2021

Conversation

AndrewGable
Copy link
Contributor

@AndrewGable AndrewGable commented Mar 19, 2021 •
edited
Loading

Details

We were running into an error when uploading a newer iOS version and the current iOS testflight is in review. In this case we've instructed fastlane to update the current iOS version in review, with the newer version. When fastlane attempted to do that, it threw an error:

fastlane-2.176.0/spaceship/lib/spaceship/connect_api/api_client.rb:181:in `handle_response': \e[31m[!] undefined method `status' for nil:NilClass\e[0m (NoMethodError)`.

It sounds like here: fastlane/fastlane#17910 (comment) people are able to use the latest version of fastlane to fix this.

Fixed Issues

Fixes broken iOS builds from uploading

Tests

  1. Merge this PR
  2. Verify iOS is able to upload without any failures

@AndrewGable AndrewGable self-assigned this Mar 19, 2021
@AndrewGable AndrewGable requested a review from a team as a code owner March 19, 2021 21:57
@botify botify requested review from pecanoro and removed request for a team March 19, 2021 21:57
roryabraham
roryabraham approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's hope this works!

@roryabraham roryabraham merged commit 35fc713 into master Mar 19, 2021
@roryabraham roryabraham deleted the andrew-fastlane-update branch March 19, 2021 22:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@pecanoro pecanoro pecanoro approved these changes

Assignees

@AndrewGable AndrewGable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewGable @pecanoro @roryabraham