Fix: Chat - Height of edit field is different for mWeb and native app #18214

chrispader · 2023-04-30T18:26:32Z

@roryabraham @sonialiap

Details

Fixes the inconsistent compose box heights for native and mWeb.

Fixed Issues

$ #11694
PROPOSAL: #11694 (comment)

Tests

Verify that no errors appear in the JS console

Launch the app
Navigate to any chat
Send a message
Long press on it > Edit
Keep pressing "Enter", until the compose box doesn't increase in size anymore
Ensure that it has 6 (full) lines in total on both native and mWeb (one web, there might be a slightly cut-off line extra)

Offline tests

None needed

QA Steps

Verify that no errors appear in the JS console

Same as normal tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

…nt-for-mWeb-and-native

melvin-bot · 2023-05-19T20:25:44Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…nt-for-mWeb-and-native

chrispader · 2023-05-20T10:59:35Z

@roryabraham ready for review! 🚀

rushatgabhane · 2023-05-20T19:42:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

roryabraham

This code LGTM, just waiting on @rushatgabhane to test + approve

rushatgabhane · 2023-05-20T19:54:36Z

src/components/Composer/index.android.js

@@ -4,10 +4,12 @@ import PropTypes from 'prop-types';
 import _ from 'underscore';
 import RNTextInput from '../RNTextInput';
 import themeColors from '../../styles/themes/default';
-import CONST from '../../CONST';


NAB: I think we should rename CONST.COMPOSER_MAX_HEIGHT to MINIMUM_PIXEL_DISTANCE

App/src/components/SwipeableView/index.native.js

Line 17 in 38e1566

const minimumPixelDistance = CONST.COMPOSER_MAX_HEIGHT;

rushatgabhane · 2023-05-22T17:28:44Z

src/components/Composer/index.ios.js

@@ -100,12 +103,13 @@ class Composer extends React.Component {
            <RNTextInput
                autoComplete="off"
                placeholderTextColor={themeColors.placeholderText}
+                maxHeight={this.props.isComposerFullSize ? '100%' : undefined}


Unrelated:
@roryabraham I was thinking if the composer should occupy all available vertical space. It's not related to the PR, but should I bring this to open-source channel?

rushatgabhane

@roryabraham LGTM! 🚀

OSBotify · 2023-05-22T22:34:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-22T23:49:39Z

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-25T00:21:31Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.17-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Christoph Pader added 10 commits April 30, 2023 20:13

fix: all compose boxes should have same max height

92dc94e

use smaller compose box on devices with small screen width

f7d39ef

revert behaviour in web compoese box

6000f83

fix fullscreen mode

7ddb519

remove maxHeight from android

7eca13d

remove numberOfLines prop

0031029

revert code styling changes

24bcf64

Merge branch 'main' into @chrispader/fix/height-of-edit-field-differe…

1ab7337

…nt-for-mWeb-and-native

remove unused import

e9fcbe8

Merge branch 'main' into @chrispader/fix/height-of-edit-field-differe…

8b716eb

…nt-for-mWeb-and-native

chrispader marked this pull request as ready for review May 19, 2023 20:25

chrispader requested a review from a team as a code owner May 19, 2023 20:25

melvin-bot bot requested review from deetergp and removed request for a team May 19, 2023 20:25

deetergp requested a review from rushatgabhane May 19, 2023 20:50

Merge branch 'main' into @chrispader/fix/height-of-edit-field-differe…

f743f24

…nt-for-mWeb-and-native

roryabraham approved these changes May 22, 2023

View reviewed changes

rushatgabhane approved these changes May 22, 2023

View reviewed changes

deetergp approved these changes May 22, 2023

View reviewed changes

deetergp merged commit f2b41c4 into Expensify:main May 22, 2023

OSBotify mentioned this pull request May 22, 2023

Deploy Checklist: New Expensify 2023-05-22 #19422

Closed

62 tasks

naveensingh mentioned this pull request May 24, 2023

[HOLD for payment 2023-06-21] [$1000] Chat - Height of edit field is different for mWeb and native app @thesahindia #11694

Closed

allroundexperts mentioned this pull request May 26, 2023

Migrate ReportActionCompose to PressableWithFeedback #19602

Merged

57 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Chat - Height of edit field is different for mWeb and native app #18214

Fix: Chat - Height of edit field is different for mWeb and native app #18214

chrispader commented Apr 30, 2023 •

edited

Loading

melvin-bot bot commented May 19, 2023

chrispader commented May 20, 2023

rushatgabhane commented May 20, 2023 •

edited

Loading

roryabraham left a comment

rushatgabhane May 20, 2023

rushatgabhane May 22, 2023 •

edited

Loading

rushatgabhane left a comment

OSBotify commented May 22, 2023

OSBotify commented May 22, 2023

OSBotify commented May 25, 2023

Fix: Chat - Height of edit field is different for mWeb and native app #18214

Fix: Chat - Height of edit field is different for mWeb and native app #18214

Conversation

chrispader commented Apr 30, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 19, 2023

chrispader commented May 20, 2023

rushatgabhane commented May 20, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

roryabraham left a comment

Choose a reason for hiding this comment

rushatgabhane May 20, 2023

Choose a reason for hiding this comment

rushatgabhane May 22, 2023 • edited Loading

Choose a reason for hiding this comment

rushatgabhane left a comment

Choose a reason for hiding this comment

OSBotify commented May 22, 2023

OSBotify commented May 22, 2023

OSBotify commented May 25, 2023

chrispader commented Apr 30, 2023 •

edited

Loading

rushatgabhane commented May 20, 2023 •

edited

Loading

rushatgabhane May 22, 2023 •

edited

Loading