diff --git a/src/languages/en.js b/src/languages/en.js index 37fbc63cc578..29f53eccd685 100755 --- a/src/languages/en.js +++ b/src/languages/en.js @@ -202,7 +202,7 @@ export default { beginningOfChatHistoryPolicyExpenseChatPartTwo: ' and ', beginningOfChatHistoryPolicyExpenseChatPartThree: ' starts here! 🎉 This is the place to chat, request money and settle up.', }, - newMessageCount: ({count}) => `${count} new message${count > 1 ? 's' : ''}`, + newMessages: 'New messages', reportTypingIndicator: { isTyping: 'is typing...', areTyping: 'are typing...', diff --git a/src/languages/es.js b/src/languages/es.js index d0dad9e78736..b5b3671cdf5b 100644 --- a/src/languages/es.js +++ b/src/languages/es.js @@ -202,7 +202,7 @@ export default { beginningOfChatHistoryPolicyExpenseChatPartTwo: ' y ', beginningOfChatHistoryPolicyExpenseChatPartThree: ' empieza aquí! :tada: Este es el lugar donde chatear, pedir dinero y pagar.', }, - newMessageCount: ({count}) => `${count} mensaje${count > 1 ? 's' : ''} nuevo${count > 1 ? 's' : ''}`, + newMessages: 'Mensajes nuevos', reportTypingIndicator: { isTyping: 'está escribiendo...', areTyping: 'están escribiendo...', diff --git a/src/libs/actions/Report.js b/src/libs/actions/Report.js index 4cf9102acfd7..c9253e6d5033 100644 --- a/src/libs/actions/Report.js +++ b/src/libs/actions/Report.js @@ -416,16 +416,6 @@ function fetchIOUReportByID(iouReportID, chatReportID, shouldRedirectIfEmpty = f }); } -/** - * @param {Number} reportID - * @param {Number} sequenceNumber - */ -function setNewMarkerPosition(reportID, sequenceNumber) { - Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, { - newMarkerSequenceNumber: sequenceNumber, - }); -} - /** * Get the private pusher channel name for a Report. * @@ -684,7 +674,7 @@ function createOptimisticReport(participantList) { lastActorEmail: '', lastMessageHtml: '', lastMessageText: null, - lastReadSequenceNumber: undefined, + lastReadSequenceNumber: 0, lastMessageTimestamp: 0, lastVisitedTimestamp: 0, maxSequenceNumber: 0, @@ -1121,7 +1111,6 @@ function markCommentAsUnread(reportID, sequenceNumber) { onyxMethod: CONST.ONYX.METHOD.MERGE, key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`, value: { - newMarkerSequenceNumber: sequenceNumber, lastReadSequenceNumber: newLastReadSequenceNumber, lastVisitedTimestamp: Date.now(), unreadActionCount: calculateUnreadActionCount(reportID, newLastReadSequenceNumber, maxSequenceNumber), @@ -1523,12 +1512,6 @@ function viewNewReportAction(reportID, action) { return; } - // When a new message comes in, if the New marker is not already set (newMarkerSequenceNumber === 0), set the marker above the incoming message. - const report = lodashGet(allReports, 'reportID', {}); - if (lodashGet(report, 'newMarkerSequenceNumber', 0) === 0 && report.unreadActionCount > 0) { - setNewMarkerPosition(reportID, report.lastReadSequenceNumber + 1); - } - Log.info('[LOCAL_NOTIFICATION] Creating notification'); LocalNotification.showCommentNotification({ reportAction: action, @@ -1589,7 +1572,6 @@ export { addAttachment, reconnect, updateNotificationPreference, - setNewMarkerPosition, subscribeToReportTypingEvents, subscribeToUserEvents, subscribeToReportCommentPushNotifications, diff --git a/src/pages/home/ReportScreen.js b/src/pages/home/ReportScreen.js index d2c114335e53..717963c3dd49 100644 --- a/src/pages/home/ReportScreen.js +++ b/src/pages/home/ReportScreen.js @@ -53,9 +53,6 @@ const propTypes = { /** The largest sequenceNumber on this report */ maxSequenceNumber: PropTypes.number, - /** The current position of the new marker */ - newMarkerSequenceNumber: PropTypes.number, - /** Whether there is an outstanding amount in IOU */ hasOutstandingIOU: PropTypes.bool, diff --git a/src/pages/home/report/FloatingMessageCounter/index.js b/src/pages/home/report/FloatingMessageCounter/index.js index fb9dfba7c362..7025d5a67a4f 100644 --- a/src/pages/home/report/FloatingMessageCounter/index.js +++ b/src/pages/home/report/FloatingMessageCounter/index.js @@ -11,25 +11,17 @@ import withLocalize, {withLocalizePropTypes} from '../../../../components/withLo import FloatingMessageCounterContainer from './FloatingMessageCounterContainer'; const propTypes = { - /** Count of new messages to show in the badge */ - count: PropTypes.number, + /** Whether the New Messages indicator is active */ + isActive: PropTypes.bool, - /** Whether the marker is active */ - active: PropTypes.bool, - - /** Callback to be called when user closes the badge */ - onClose: PropTypes.func, - - /** Callback to be called when user clicks the marker */ + /** Callback to be called when user clicks the New Messages indicator */ onClick: PropTypes.func, ...withLocalizePropTypes, }; const defaultProps = { - count: 0, - active: false, - onClose: () => {}, + isActive: false, onClick: () => {}, }; @@ -45,7 +37,7 @@ class FloatingMessageCounter extends PureComponent { } componentDidUpdate() { - if (this.props.active && this.props.count > 0) { + if (this.props.isActive) { this.show(); } else { this.hide(); @@ -93,24 +85,10 @@ class FloatingMessageCounter extends PureComponent { styles.textWhite, ]} > - {this.props.translate( - 'newMessageCount', - {count: this.props.count}, - )} + {this.props.translate('newMessages')} )} - shouldRemoveRightBorderRadius - /> -