-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Tooltip wrap issue on Safari #10504
fix: Tooltip wrap issue on Safari #10504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @danieldoglas in version: 1.1.90-0 🚀
|
@mananjadhav In the PR it says NA for mWeb, iOS and Android. Uploading No Notification when pinning and unpinning.MP4… Do we have to test in mWeb, iOS and Android too? Its failing in these environments. |
@kavimuru I don't understand what you mean here. Tooltips don't show up in mobile apps and mobile web and hence we need to skip in those environments. and I am not sure what you mean by Its failing in these environments |
@mananjadhav Sorry, the video was not loading properly. We weren't sure if the tooltip should be tested in the environments ( iOS, Android and mWeb)
We are good then. |
Details
Fixed Issues
$ #9331
Tests
Web (Chrome and Safari) and Desktop
Unpin
tooltip should be in one line without being trimmed/wrappedPR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Web (Chrome and Safari) and Desktop
Unpin
tooltip should be in one line without being trimmed/wrappedScreenshots
Web
Mac Chrome
web-tooltip-no-trim-no-wrap.mov
Mac Safari
safari-tooltip-no-trim-no-wrap.mp4
Mobile Web
NA
Desktop
desktop-tooltip-no-trim-no-wrap.mp4
iOS
NA
Android
NA