Bank account- "Continue setup" button is not disabled after selecting Start over when offline

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.5-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Workflows.
3. Click Connect bank account.
4. Click Connect manually.
5. Enter routing number and acount number > Next.
6. Click RHP back button twice.
7. Go offline.
8. Click Start over.
9. Click Yes, start over.

Expected Result:

"Continue setup" button will be disabled after selecting Start over in offline mode (production behavior).

Actual Result:

"Continue setup" button is not disabled after selecting Start over in offline mode.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6754005_1740502194742.20250226_004538.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MrMuzyk]

Caused by #55949. I'm the author of the PR and can fix it

[MrMuzyk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Continue setup" button will be disabled after selecting Start over in offline mode (production behavior).

What is the root cause of that problem?

Continue setup button doesn't have disabled prop passed when user is offline

What changes do you think we should make in order to solve the problem?

Pass disabled prop to Continue setup button when pendingAction exists

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

n/a

[github-actions]

⚠️ @MrMuzyk Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[MrMuzyk]

@IuliiaHerets Should the Continue button be disabled when user is offline in general or only after he presses Start over?

[neil-marcellini]

Reverting that PR to fix this.

[kavimuru]

Fixed

bandicam.2025-02-26.00-15-47-265.mp4

[MonilBhavsar]

Thank you!