Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-03-05] [Due for payment 2025-03-05] Sign in - Blank page opens after clicking "Sign In here" when signing in in different session #57359

Closed
1 of 8 tasks
lanitochka17 opened this issue Feb 24, 2025 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 24, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.5-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2616811
Issue reported by: Applause - Internal Team

Action Performed:

  1. Log out of NewDot and request a new magic link as a gmail user
  2. Navigate to email and locate the magic link - change to staging if needed
  3. Open an new incognito window and navigate to the staging link
    4.Click on the link to "Sign in here" on "Here is your code" page

Expected Result:

User is logged in after clicking "Sign in here" link in incognito window, when original log in started in normal window

Actual Result:

Blank page opens after clicking "Sign in here" link in incognito window, when original log in started in normal window. User's information loads after refreshing the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome only
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6753085_1740437522078.blank_screen.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @alexpensify
@lanitochka17 lanitochka17 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 24, 2025
Copy link

melvin-bot bot commented Feb 24, 2025

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 24, 2025
Copy link

melvin-bot bot commented Feb 24, 2025

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 24, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@francoisl
Copy link
Contributor

On dev I'm getting a "Magic code expired. Go back to the original device and request a new code.", which is not exactly the same. Going to test on staging to confirm.

@francoisl
Copy link
Contributor

This appears to be coming from #55966, reverting locally solves the issue. Going to see if I can find a way to solve, otherwise will revert.

cc @WojtekBoman @deetergp @c3024 if you're around

@francoisl
Copy link
Contributor

I can't figure out a fix, going to revert for now.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Hourly KSv2 labels Feb 25, 2025
@francoisl
Copy link
Contributor

Fix tested on staging, removing blocker label.

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Feb 25, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 26, 2025
@melvin-bot melvin-bot bot changed the title Sign in - Blank page opens after clicking "Sign In here" when signing in in different session [Due for payment 2025-03-05] Sign in - Blank page opens after clicking "Sign In here" when signing in in different session Feb 26, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 26, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 26, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.5-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-05. 🎊

@francoisl francoisl removed the Awaiting Payment Auto-added when associated PR is deployed to production label Feb 26, 2025
@francoisl
Copy link
Contributor

This was all taken care of internally, no payments required.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 26, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-03-05] Sign in - Blank page opens after clicking "Sign In here" when signing in in different session [Due for payment 2025-03-05] [Due for payment 2025-03-05] Sign in - Blank page opens after clicking "Sign In here" when signing in in different session Feb 26, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.6-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-05. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants