Deploy Checklist: New Expensify 2025-02-24

[github-actions]

Release Version: 9.1.5-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• (2/2) Add support for all reportAction types in ChatListItem - use ReportActionItem in ChatListItem #54228
• fix: incorrect page is displayed when refreshing the page #54680
• Fix - Workspace - Non-admin is not instantly removed from #admins member list after being demoted #54792
• feat: Connect USD and nonUSD VBA flows #55949
• Migrate AuthScreens to useOnyx v2 #55966
• fix: correct next step message #56221
• Fix optimistic message created while offline is marked as unread #56628
• feat: update policy expense chat name #56735
• Add manager mctest tooltips to create expense flow #56759
• Add border radius to auto complete #56866
• Only show review action to submitter or approver #56890
• Add Troubleshoot menu to PublicScreens #56926
• Fix/56339 fetch available cards to assign #57003
• RHP for Add approval workflow doesn't appear after upgrading the workspace #57095
• [No QA] Fix commenting on Mobile-Expensify AdHoc workflow #57182
• Fix - Bulk Delete doesn't remove the deleted rows from the UI #57208
• fix: Workspace chat tooltip is shown incorrectly #57220
• Company cards - After enabling company card, tapping new card directs to hmm not here page #57221
• Update Android and IOS download link to Hybrid App #57226
• Fix domain list when picking domain for travel #57249
• [No QA] Set env variable to fix fastlane s3 uploading #57317
• [NoQA] Update the workflow to notify about workflow failures #57324
• Update Create expense Track task #57329
• Revert "(2/2) Add support for all reportAction types in ChatListItem - use ReportActionItem in ChatListItem" #57360
• [CP Staging] Revert #55966 / Fix "just sign in here" Magic Code page link #57362
• Revert "Merge pull request #56926 from callstack-internal/feat/add-tr… #57421
• Revert "feat: Connect USD and nonUSD VBA flows" #57422
• Revert "Add manager mctest tooltips to create expense flow" #57433

Deploy Blockers:

• [$250] Hybrid - Android - Room - Big empy space displayed below composer when new room is created #57271
• [Due for payment 2025-03-05] [Due for payment 2025-03-05] Reports - Unable to play videos from Reports > Chats #57340
• Close account - App opens Debug console page after closing account #57341
• [Due for payment 2025-03-05] [Due for payment 2025-03-05] Reports - Not here page opens when opening system message from #admins #57343
• [Due for payment 2025-03-05] [Due for payment 2025-03-05] Reports - Workspace avatar for invoice chat is showing "unavailable" type avatar #57344
• [Due for payment 2025-03-05] [Due for payment 2025-03-05] Reports - Expense preview shows "owes" instead of "paid" when the expense is paid #57347
• Login - Not here page opens after log out and log in with another account #57349
• Expense - "Try it out" button is not functional #57351
• [Due for payment 2025-03-05] [Due for payment 2025-03-05] Reports - Reply count appears and disappears after submitting expense to report with replies #57352
• Web - Reports - Clicking on expense preview does not open expense report as RHP #57355
• [Due for payment 2025-03-05] [Due for payment 2025-03-05] Reports - User´s Email changes to "You" on system message of deleted WS if opened from Reports #57357
• [Due for payment 2025-03-05] [Due for payment 2025-03-05] Sign in - Blank page opens after clicking "Sign In here" when signing in in different session #57359
• [Due for payment 2025-03-05] [Due for payment 2025-03-05] Reports - "0,00"seen as amount for some time when categorizing expense from Chats on Reports #57363
• Expense - Clicking on tooltip is not functional #57365
• [$250] Chat - Re-selection is required to change payment method from Pay elsewhere to Expensify #57381
• Bank account-Continue button takes user to account details page, Next button unresponsive #57408
• [$250] Bank account - Bank account icons are green when not hovered or clicked #57409
• Bank account - Back arrow on Validate your bank account page is unresponsive #57410
• Bank account - Back button closes RHP instead of returning to initial page after continue setup #57413
• Bank account- "Continue setup" button is not disabled after selecting Start over when offline #57415

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[rlinoz]

Checking off #57249

[francoisl]

#57359 tested on staging, checking off

[izarutskaya]

Regression is at 93% completed

PRs
#54228 - found issue #54228 (comment)
#56759 - failing with issue #56759 (comment)
#56866 - can we check off based this comment ?#56866 (comment)

Deploy Blockers:
#57340
#57341
#57343
#57344
#57347
#57349
#57351
#57352
#57357
#57363
#57381

[luacmartins]

Checking off #56866. Since the failing KI is expected.

[Julesssss]

Checking off #57349 - resolved by previous fix & CP

[yuwenmemon]

Checking off #57351 since it's expected behavior for now behind a beta.

[carlosmiceli]

Checking off #57341 -> reverted and CPed.

[kavimuru]

Regression is just couple steps left.
unchecked PRs:
#55949 failing with #57408 and #57410
#56890 pending desktop validation
#57003 pending validation on mweb, desktop and android platforms
#57249 #57249 (comment)
#56866 (comment)
#54792 (comment)
#56759 failing with #57365
#57362 failing with #48378

[chiragsalian]

We CP'd a revert that addresses the following and the revert PR is currently on staging,

• Bank account-Continue button takes user to account details page, Next button unresponsive #57408
• [$250] Bank account - Bank account icons are green when not hovered or clicked #57409
• Bank account - Back arrow on Validate your bank account page is unresponsive #57410
• Bank account - Back button closes RHP instead of returning to initial page after continue setup #57413
• Bank account- "Continue setup" button is not disabled after selecting Start over when offline #57415

@kavimuru can you retest those blockers on staging and if it does not reproduce can you check off those items from the checklist?

[chiragsalian]

I checked off,

• Revert "(2/2) Add support for all reportAction types in ChatListItem - use ReportActionItem in ChatListItem" #57360
• [CP Staging] Revert #55966 / Fix "just sign in here" Magic Code page link #57362
• Revert "Merge pull request #56926 from callstack-internal/feat/add-tr… #57421

since they have been tested.

[kavimuru]

Regression is completed.
unchecked PRs:
#54792 (comment)
#55949 failing with #57408 and #57410
#56759 failing with #57365

The following Critical Regression Test Cases failed because of the these issues:

• TestRail Link - Issue Sign in – Unable to login via Magic link, Magic code expired appears #48378
• TestRail Link - Issue Onboarding - The 'take a 2-minute tour' task doesn’t get auto-checked when finished #56502
• TestRail Link - Issue [$250] HybridApp - Can't validate the account of a new sign-up on a controlled private domain #55771
• TestRail Link - Issue [$250] Android - Onboarding modal - "Do you use any accounting software?" modal is not shown #55670

[kavimuru]

@chiragsalian the following blockers are not reproducible now. I checked those off
#57408
#57409
#57410
#57413
#57415

[chiragsalian]

Checked off #56759, i reverted it
Checked off #57433, its the revert PR of the above
Checked off #54792, it doesn't look like a blocking concern.
Checked off #55949, it was reverted.
Checked off #57381, the revert PR #57433 resolved this blocker.

[chiragsalian]