mWeb - Expensify Card - Unable to navigate back to settings after Reporting card as Fraud

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.4-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5640930
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 12 Pro / iOS 17.4.1
App Component: Workspace Settings

Action Performed:

1. Launch ND .
2. Assign Expensify Card to user
   3 Navigate to Wallet
3. Select Assigned card in Assigned Cards
4. Tap report virtual card fraud
5. Tap Deactivate Card
6. Enter magic code
7. On the confirmation screen Tap app back button.
8. Tap app back button again
9. Tap app back button again

Expected Result:

User should navigate back to Settings

Actual Result:

User is not able to navigate back from Wallet and Card pages

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/f10add12-ecc6-49bb-9018-bbebce160601
https://github.com/user-attachments/assets/4fda9ffe-e4a0-4a6e-b2c8-7bc1378880d5

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is not able to navigate back from Wallet and Card pages

What is the root cause of that problem?

When clicking back button in Card page, we call Navigation.navigate

App/src/pages/settings/Wallet/ExpensifyCardPage.tsx

Line 149 in c87ab01

onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WALLET)}

And when clicking back button in Wallet page, we call Navigation.goBack

App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx

Line 397 in c87ab01

onBackButtonPress={() => Navigation.goBack()}

This traps us in a loop: navigate to wallet page -> go back to card page -> navigate to wallet page ....

What changes do you think we should make in order to solve the problem?

We should use Navigation.goBack here

App/src/pages/settings/Wallet/ExpensifyCardPage.tsx

Line 149 in c87ab01

onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WALLET)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[jliexpensify]

I'm unsure if this is an actual deploy blocker but it seems like an issue - @grgia will know best here.

[grgia]

@jliexpensify does this occur on prod?

[jliexpensify]

@grgia I believe I can reproduce it on Android Hybrid app (9.1.4.0) without even cancelling a card.

Repro steps:

1. Head to Wallet
2. Click on E.Card
3. Click on back button
4. This brings you to the Wallet page
5. Click on back button (on Wallet page)
6. This cycles between the E.Card page and the Wallet page (i.e. there's a loop)

But if I use swipe gestures, I can navigate back - but not by hitting the back button with my finger/thumb.

Video:

screen-20250224-204503.mp4

[jliexpensify]

So pretty much @daledah's comment here:

This traps us in a loop: navigate to wallet page -> go back to card page -> navigate to wallet page ....

[jliexpensify]

Ugh ignore me...that's staging 🤦

EDIT: I can't repro on prod (Android)

[mountiny]

We have reverted potentially related PR cc @WojtekBoman #57320 this might not be reproducible after this revert

[Kicu]

I'm monitoring this issue, so if you can or cannot reproduce this then please write a comment. If someone needs to work on this then we might help, I have some partial context related to this PR

[mountiny]

Asked for a retest https://expensify.slack.com/archives/C9YU7BX5M/p1740408684514249

[mountiny]

The revert fixed it https://expensify.slack.com/archives/C9YU7BX5M/p1740409048906349?thread_ts=1740408684.514249&cid=C9YU7BX5M