Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Hybrid - Android - Room - Big empy space displayed below composer when new room is created #57271

Closed
1 of 8 tasks
IuliiaHerets opened this issue Feb 22, 2025 · 16 comments
Closed
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 22, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.4-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12
App Component: Chat Report View

Action Performed:

  1. Open the Expensify app.
  2. Tap on the FAB and select "Create Chat"
  3. Tap on "Room" and finish the creation flow.
  4. Check the composer behaviour and the space below it, when redirected to the new created room.

Expected Result:

Composer should be displayed at the bottom of the screen when the new room conversation is created.

Actual Result:

Big empty space is displayed below the composer when a new room is created.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6750486_1740181192360.Compose.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021894116929176870819
  • Upwork Job ID: 1894116929176870819
  • Last Price Increase: 2025-02-24
Issue OwnerCurrent Issue Owner: @ZhenjaHorbach
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Feb 22, 2025
Copy link

melvin-bot bot commented Feb 22, 2025

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MonilBhavsar
Copy link
Contributor

@IuliiaHerets any idea why this was labeled as DeployBlocker and not DeployBlockerCash?

@IuliiaHerets
Copy link
Author

@MonilBhavsar I put DeployBlockerCash label because the issue was not repro with staging server off

screen-20250222-063311.mp4

@MonilBhavsar
Copy link
Contributor

Makes sense. Looks like the label added was Deployblocker where you wanted to put DeployBlockerCash, right?

@MonilBhavsar MonilBhavsar added DeployBlockerCash This issue or pull request should block deployment and removed DeployBlocker Indicates it should block deploying the API labels Feb 24, 2025
Copy link

melvin-bot bot commented Feb 24, 2025

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 24, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot removed the Overdue label Feb 24, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 24, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@marcochavezf marcochavezf added the External Added to denote the issue can be worked on by a contributor label Feb 24, 2025
@melvin-bot melvin-bot bot changed the title Hybrid - Android - Room - Big empy space displayed below composer when new room is created [$250] Hybrid - Android - Room - Big empy space displayed below composer when new room is created Feb 24, 2025
Copy link

melvin-bot bot commented Feb 24, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021894116929176870819

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 24, 2025
Copy link

melvin-bot bot commented Feb 24, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

@marcochavezf
Copy link
Contributor

Check out the open StagingDeployCash deploy checklist

The deploy checklist doesn't correspond to this version. The deploy checklist corresponds to this one.

@marcochavezf
Copy link
Contributor

marcochavezf commented Feb 24, 2025

A likely culprit is #57110 (“Adjust adaptStateIfNecessary to push a split navigator without a sidebar screen”). But then it was reverted in the PR #57320 (“[CP Staging] Revert ‘Adjust adaptStateIfNecessary…’”)

@marcochavezf
Copy link
Contributor

It's possible the bug is not happening, @IuliiaHerets can you re-test, please?

@marcochavezf marcochavezf added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. Hourly KSv2 labels Feb 24, 2025
Copy link

melvin-bot bot commented Feb 24, 2025

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

@IuliiaHerets
Copy link
Author

IuliiaHerets commented Feb 24, 2025

@MonilBhavsar No, you confused me a bit and I made a typo in the comment, we put exactly DeployBlocker label if the issue is not reproduced in staging with SS off

@IuliiaHerets
Copy link
Author

@marcochavezf Tester can't repro the issue in the latest build (9.1.5-0)

screen-20250224-194102.mp4

@marcochavezf
Copy link
Contributor

Oh cool, thanks @IuliiaHerets for the testing! We can close it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants