Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-03-05] Fix Android Standalone builds #57266

Open
francoisl opened this issue Feb 21, 2025 · 7 comments
Open

[Due for payment 2025-03-05] Fix Android Standalone builds #57266

francoisl opened this issue Feb 21, 2025 · 7 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Improvement Item broken or needs improvement. Weekly KSv2

Comments

@francoisl
Copy link
Contributor

francoisl commented Feb 21, 2025

Problem

The upload_google_play_internal part of standalone Android builds is failing. Our QA team uses standalone builds to determine whether issues are hybrid-only, or on both Standalone and Hybrid.

Recent failure examples:

Action logs as an example (from this build)

+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|                                                                                                                                                            Used plugins                                                                                                                                                             |
+-------------------------------------------+---------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Plugin                                    | Version | Action                                                                                                                                                                                                                                                                        |
+-------------------------------------------+---------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| fastlane-plugin-aws_s3                    | 2.1.0   | aws_s3                                                                                                                                                                                                                                                                        |
| fastlane-plugin-firebase_app_distribution | 0.10.0  | firebase_app_distribution, firebase_app_distribution_add_testers, firebase_app_distribution_create_group, firebase_app_distribution_delete_group, firebase_app_distribution_get_latest_release, firebase_app_distribution_get_udids, firebase_app_distribution_remove_testers |
+-------------------------------------------+---------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

[22:53:29]: Sending anonymous analytics information
[22:53:29]: Learn more at https://docs.fastlane.tools/#metrics
[22:53:29]: No personal or sensitive data is sent.
[22:53:29]: You can disable this by adding `opt_out_usage` at the top of your Fastfile
[22:53:29]: ---------------------------
[22:53:29]: --- Step: opt_out_usage ---
[22:53:29]: ---------------------------
[22:53:29]: Disabled upload of used actions
[22:53:29]: Driving the lane 'android upload_google_play_internal' 🚀
[22:53:29]: Error setting value '/tmp/artifacts/' for option 'aab'
[22:53:29]: You passed invalid parameters to 'upload_to_play_store'.
[22:53:29]: Check out the error below and available options by running `fastlane action upload_to_play_store`
+-----------------------------------------------------+
|                    Lane Context                     |
+---------------+-------------------------------------+
| PLATFORM_NAME | android                             |
| LANE_NAME     | android upload_google_play_internal |
+---------------+-------------------------------------+
[22:53:29]: Called from Fastfile at line 190
[22:53:29]: ```
[22:53:29]:     1[8](https://github.com/Expensify/App/actions/runs/13466411850/job/37633588665#step:7:9)8:	    # Google is very unreliable, so we retry a few times
[22:53:2[9](https://github.com/Expensify/App/actions/runs/13466411850/job/37633588665#step:7:10)]:     189:	    ENV["SUPPLY_UPLOAD_MAX_RETRIES"]="5"
[22:53:29]:  => 190:	    upload_to_play_store(
[22:53:29]:     191:	      package_name: "com.expensify.chat",
[22:53:29]:     192:	      json_key: './android/app/android-fastlane-json-key.json',
[22:53:29]: ```
[22:53:29]: aab file is not an aab

+------------------------------------+
|          fastlane summary          |
+------+---------------+-------------+
| Step | Action        | Time (in s) |
+------+---------------+-------------+
| 1    | opt_out_usage | 0           |
+------+---------------+-------------+


[!] aab file is not an aab
[22:53:29]: fastlane finished with errors

Solution

Figure out cause, fix it


Ref. Internal discussion

Issue OwnerCurrent Issue Owner: @joekaufmanexpensify
@francoisl francoisl added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. labels Feb 21, 2025
Copy link

melvin-bot bot commented Feb 21, 2025

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@joekaufmanexpensify
Copy link
Contributor

@jnowakow it sounds like @francoisl / @Julesssss think you might be a good candidate for this one. any interest?

@melvin-bot melvin-bot bot removed the Overdue label Feb 24, 2025
@jnowakow
Copy link
Contributor

It's strange because it fails in buildAndroid.yml workflow on step Build Android app (retryable) but for some reason mark this step as successful:

Image

Upload job fails because there is no aab file (which is understandable as build failed)

@jnowakow
Copy link
Contributor

Hybrid app seems to be built and uploaded without issues

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 25, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 26, 2025
@melvin-bot melvin-bot bot changed the title Fix Android Standalone builds [Due for payment 2025-03-05] Fix Android Standalone builds Feb 26, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 26, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.6-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @jnowakow does not require payment (Contractor)

Copy link

melvin-bot bot commented Feb 26, 2025

@joekaufmanexpensify @jnowakow The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants