Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Lib] heic-to #55777

Open
Beamanator opened this issue Jan 27, 2025 · 4 comments
Open

[New Lib] heic-to #55777

Beamanator opened this issue Jan 27, 2025 · 4 comments
Assignees
Labels
AutoAssignerAppLibraryReview Auto assign someone to review a new library being added to App Weekly KSv2

Comments

@Beamanator
Copy link
Contributor

Beamanator commented Jan 27, 2025

In order to properly evaluate if a new library can be added to package.json, please fill out this request form. It will be automatically assigned someone from our review team that will go through and vet the library.

In order to add any new production dependency, it must be approved by the App Deployer team. They will evaluate the library and decide if it's something we want to move forward with or if other alternatives should be explored.

Note: This is only for production dependencies. While we don't want people to add packages to dev-dependencies willy-nilly, we recognize that there isn't as great of a need there to secure them.

Name of library: heic-to

Note: We previously agreed to adding the library heic2any here, but since then we noticed that that lib doesn't work for the newest version of HEIC / HEIF - see alexcorvi/heic2any#61

Details

  • Link to package: https://github.com/hoppergee/heic-to
  • Problem solved by using this package:
  • Number of stars in GH: 107
  • Number of monthly downloads: Unknown (not on NPM)
  • Number of releases in the last year: 10
  • Level of activity in the repo: Low
  • Alternatives: None that we've seen for complete fix, but heic2any does well for older versions of HEIC/HEIF files
  • Are security concerns brought up and addressed in the library's repo?

Not that I know of, but this is not the type of library that would raise any security concerns.

@Beamanator Beamanator added AutoAssignerAppLibraryReview Auto assign someone to review a new library being added to App Weekly KSv2 labels Jan 27, 2025
@Beamanator Beamanator self-assigned this Jan 27, 2025
Copy link

melvin-bot bot commented Jan 27, 2025

Current assignee @Beamanator is eligible for the AutoAssignerAppLibraryReview assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Jan 27, 2025

New Library Review

  • Are all the answers in the main description filled out properly and make sense?
  • Who maintains the library and how well is it maintained?
  • How viable are the alternatives?
  • Should we build it ourselves instead?

Once these questions are answered, start a thread in #engineering-chat, ping the @app_deployers group, and call for a vote to accept the new library. Once the vote is complete, update this issue with the outcome and procede accordingly. Here is a sample post:

Hey @app_deployers,

There is a request to add a new library to App that we need to consider. Please look at this GH and then vote :+1: or :-1: on accepting this new library or not.

GH_LINK

@Beamanator
Copy link
Contributor Author

Waiting for Contrib & C+ to review before sending to the group

@melvin-bot melvin-bot bot removed the Overdue label Feb 11, 2025
@melvin-bot melvin-bot bot added the Overdue label Feb 19, 2025
@Beamanator
Copy link
Contributor Author

updated, will bring to slack next week

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerAppLibraryReview Auto assign someone to review a new library being added to App Weekly KSv2
Projects
None yet
Development

No branches or pull requests

1 participant