-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Lib] heic-to #55777
Comments
Current assignee @Beamanator is eligible for the AutoAssignerAppLibraryReview assigner, not assigning anyone new. |
New Library Review
Once these questions are answered, start a thread in #engineering-chat, ping the
|
Waiting for Contrib & C+ to review before sending to the group |
updated, will bring to slack next week |
In order to properly evaluate if a new library can be added to
package.json
, please fill out this request form. It will be automatically assigned someone from our review team that will go through and vet the library.In order to add any new production dependency, it must be approved by the App Deployer team. They will evaluate the library and decide if it's something we want to move forward with or if other alternatives should be explored.
Note: This is only for production dependencies. While we don't want people to add packages to dev-dependencies willy-nilly, we recognize that there isn't as great of a need there to secure them.
Name of library: heic-to
Note: We previously agreed to adding the library
heic2any
here, but since then we noticed that that lib doesn't work for the newest version of HEIC / HEIF - see alexcorvi/heic2any#61Details
heic2any
does well for older versions of HEIC/HEIF filesNot that I know of, but this is not the type of library that would raise any security concerns.
The text was updated successfully, but these errors were encountered: