Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Improve eReceipt visually in New Dot #55083

Open
anmurali opened this issue Jan 10, 2025 · 43 comments
Open

[$250] Improve eReceipt visually in New Dot #55083

anmurali opened this issue Jan 10, 2025 · 43 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Design External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Monthly KSv2 Reviewing Has a PR in review

Comments

@anmurali
Copy link

anmurali commented Jan 10, 2025

When I go to approve expenses that @cole submits from his Expensify Card, I keep finding myself asking him to upload a receipt. That's because the receipt in the app looks like this
image
Looks like there's no receipt but that's actually an eReceipt and is sufficient from a compliance standpoint.

Let's update the design for an eReceipt to look more like a receipt.

CleanShot 2025-01-13 at 09 26 35@2x

Let's also make sure the eReceipt takes up full width in the various thumbnail areas where its used, such as:

Image

Image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021878720719253020177
  • Upwork Job ID: 1878720719253020177
  • Last Price Increase: 2025-01-13
  • Automatic offers:
    • ishpaul777 | Reviewer | 105839173
    • mkzie2 | Contributor | 105839174
Issue OwnerCurrent Issue Owner: @ishpaul777
@anmurali anmurali added Daily KSv2 Improvement Item broken or needs improvement. Design labels Jan 10, 2025
Copy link

melvin-bot bot commented Jan 10, 2025

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

@shawnborton
Copy link
Contributor

I like all of them except the plug that isn't plugged in one. That somehow suggests to me that something needs doing.

The icons are added depending on the MCC category. So that might be what we use for utility bills or something.

@dannymcclain
Copy link
Contributor

Giving this one to you since you've done all the work for it!

@shawnborton
Copy link
Contributor

Putting the receipt edges here for posterity so I don't lose them: receiptedge

@shawnborton
Copy link
Contributor

Very generous with your GH coinage today, thank you again for filling my cup.

@shawnborton
Copy link
Contributor

I think we can probably make this external @anmurali - thoughts? Also cc @grgia since you were the original engineer behind our NewDot eReceipts...

@anmurali
Copy link
Author

If its clear from my issue description what the contributor needs to do, let's slap an External on it. I wasn't sure I had described it sufficiently clearly

@melvin-bot melvin-bot bot added the Overdue label Jan 13, 2025
@shawnborton
Copy link
Contributor

Okay, I updated the original post with a more clear screenshot. I would still love @grgia 's thoughts on how to implement this best though, but I think we can at least start getting proposals for this one.

@melvin-bot melvin-bot bot removed the Overdue label Jan 13, 2025
@shawnborton shawnborton added External Added to denote the issue can be worked on by a contributor Overdue labels Jan 13, 2025
@melvin-bot melvin-bot bot changed the title Improve eReceipt visually in New Dot [$250] Improve eReceipt visually in New Dot Jan 13, 2025
Copy link

melvin-bot bot commented Jan 13, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021878720719253020177

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 13, 2025
@melvin-bot melvin-bot bot removed the Overdue label Jan 13, 2025
Copy link

melvin-bot bot commented Jan 13, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

@shawnborton shawnborton added Overdue Bug Something is broken. Auto assigns a BugZero manager. and removed Help Wanted Apply this label when an issue is open to proposals by contributors Overdue labels Jan 13, 2025
Copy link

melvin-bot bot commented Jan 13, 2025

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 24, 2025

@shawnborton, @danieldoglas, @strepanier03, @grgia, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Jan 24, 2025

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Jan 24, 2025

📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@grgia
Copy link
Contributor

grgia commented Jan 24, 2025

LGTM @mkzie2 @ishpaul777

Let's make sure we catch the spacing between the top part of the receipt and the middle part. I can see a faint line. Would it be better to use a single SVG here?

Image

@shawnborton
Copy link
Contributor

We can also supply an entire receipt SVG to use as the BG image in case that is helpful?

Attaching here in case it's worth trying:

receipt-body.svg.zip

Copy link

melvin-bot bot commented Jan 28, 2025

@shawnborton, @strepanier03, @grgia, @ishpaul777, @mkzie2 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jan 28, 2025
@ishpaul777
Copy link
Contributor

@mkzie2 When can we expect a PR?

@melvin-bot melvin-bot bot removed the Overdue label Jan 28, 2025
@grgia
Copy link
Contributor

grgia commented Jan 29, 2025

Looks like a Draft PR is up, waiting on update from @mkzie2

@mkzie2
Copy link
Contributor

mkzie2 commented Jan 30, 2025

I'm fixing some UI bugs and will complete it tomorrow.

@melvin-bot melvin-bot bot added the Overdue label Jan 30, 2025
@ishpaul777
Copy link
Contributor

update ^

@melvin-bot melvin-bot bot removed the Overdue label Jan 30, 2025
@anmurali
Copy link
Author

anmurali commented Feb 1, 2025

@mkzie2 is there an update?

@mkzie2
Copy link
Contributor

mkzie2 commented Feb 3, 2025

Will complete this one today.

@melvin-bot melvin-bot bot added the Overdue label Feb 3, 2025
Copy link

melvin-bot bot commented Feb 3, 2025

@shawnborton, @strepanier03, @grgia, @ishpaul777, @mkzie2 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Feb 3, 2025
@mkzie2
Copy link
Contributor

mkzie2 commented Feb 3, 2025

@ishpaul777 The PR is ready.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Feb 26, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

This issue has not been updated in over 15 days. @shawnborton, @strepanier03, @grgia, @ishpaul777, @mkzie2 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Design External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

9 participants